Posted by mfer on December 3, 2007 at 3:45pm
| Project: | Audio |
| Version: | 5.x-1.3 |
| Component: | Documentation |
| Category: | task |
| Priority: | normal |
| Assigned: | kourge |
| Status: | closed (fixed) |
| Issue tags: | GHOP |
Issue Summary
The documentation in the handbook on how to theme the flash player (http://drupal.org/node/34043) is very out of date and doesn't correlate to the current version of the audio module.
Since this page was last updated the 1pixelout flasher player has been included in the module and is the default. Now, with multiple players, the theme functions have changed as well.
So, let's update the documentation.
Some relevant info:
http://www.1pixelout.net/code/audio-player-wordpress-plugin/
http://www.innovatingtomorrow.net/2007/10/22/how-theme-1pixelout-flash-p...
http://musicplayer.sourceforge.net/
This is going in as part of the Google Highly Open Participation Contest. More info to follow.
Comments
#1
GHOP issue: http://code.google.com/p/google-highly-open-participation-drupal/issues/...
Some more info:
http://www.innovatingtomorrow.net/2007/10/22/how-theme-1pixelout-flash-p...
#2
#3
Claimed by daryennaruto
#4
#5
#6
Please review the updated page.
#7
@kourge - I'm in the middle of a vacation so I could only give this a quick once over. I'll take a better look at it in a couple days. Sorry for the delay.
Can you add the image diagraming the different locations that can be themed from the 1pixelout player? That is if the image is licensed properly. If you can't add images to the node attach it and I'll change the input filter for you.
#8
@mfer
I've looked over the image (of the 1pixelout diagram) on Innovating Tomorrow and I'm not really sure what license it's under. I already have permission to change the input filter (to Documentation) and attach files, so no worries about that ;)
#9
@kourge - I'm looking into the licensing. The image is distributed with the wordpress extension which is GPL licensed. But, on the 1pixelout.net the image is displayed on a Creative Commons licensed page.
In the meantime can you roll a patch for the README.txt file on this module the provides updated theming information. It can refer back to the handbook page. It's at http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/audio/READM...
#10
I'm assuming the image is licensed under CC by 2.0 because
1) It appears on the website, which is licenses all content under CC by 2.0 and
2) GPL is meant for code, not content like images (just like CC is meant for content, not code)
So I've put the image onto the handbook page.
For README.txt, patch attached. It fixes a few punctuation and it moves
$Id$to the top.#11
This looks good to me but I sent it off to a designer/themer type (non-coder) to review.
#12
I committed the patches to DRUPAL-5 and HEAD. I'm going to leave this open until mfer signs off on the handbook pages.
#13
The handbook page looks good and the patch is committed. Marking this as closed.
@kourge - Thanks for working on this.
#14
I meant fixed. :)
#15
Yay!
#16
Automatically closed -- issue fixed for two weeks with no activity.