Replace "Sticky at top of lists" with a more meaningful equivalent
marco.robotangel - December 3, 2007 - 18:06
| Project: | Drupal |
| Version: | 7.x-dev |
| Component: | user interface text |
| Category: | task |
| Priority: | normal |
| Assigned: | Senpai |
| Status: | needs work |
| Issue tags: | beginner, GHOP, Newbie, Usability, Usability Team Approved |
Description
Try to create a new story, expand "publishing options". You will see an option "Sticky at top of lists". This is a quite unclear description, especially if you never participated in an bulletin board or have never used Drupal before.
The suggestion made at [1] is to replace it with an more meaningful equivalent: "Sticky (stays at top of content lists).". Even if you've never used Drupal before you know directly where exactly it will be shown (at the top of the content lists) and it'll stay there until you choose a different option.
Don't hurry, I'll try to fix this problem (should be just a small description to change?) on my own (want to learn something ;-) )
#1
Marking as a GHOP task so people know not to work on it.
#2
Oh nevermind. :) I see what you're doing. Unmarking as a GHOP task. But yeah, if folks could give marco.robotangel a couple days to work on this that'd be swell. :)
#3
Well, my very first patch here. I'm quite sure I've forgotten something so don't chop me up if it's not complete.
#4
Tested and working fine. The patch applies cleanly. Good work! I even like the way you worded it, and there are some around here who know how hard that is to do! ;-) I'm RTBC'ing this, so unless there are any objections to the text, it should probably get committed.
A note for you, though Marco. You should learn how to patch against core files from the root of the drupal directory. There's more info in the http://drupal.org/patch section of the Handbooks.
#5
Are there other places where this might appear? The content overview page's filter form might not be the best to apply this change as well, but a bit of a look around would help in achieving consistency.
#6
I didn't even think of that, but upon consideration, it seems like that's the only place I've ever seen it. Marco, mind doing a search through core for that phrase or others like it?
#7
Very nice patch, Marco, and good catch, Gabor.
A quick grep through core (sorry I did Drupal 5, I realize now, but I didn't have 6 on my computer)
/drupal-core/drupal-5.3 ben$ grep -nHR sticky .comes up with one important spot, other than the content overview page's filter (which should probably be changed also? Not really a space consideration is there?)
That spot is the default settings provided by content_types:
And the admin filter:
Again, ignore line numbers but I bet the files are the same in D6.
#8
will need to wait for d7 now with the lang code freeze. tag for newbie
#9
#10
#11
I am using D5 also and decided to manually change the text from "Sticky at top of lists" to "Featured Items" for my own purposes. I made these change anywhere I found the phrase "Sticky at top of lists" in both ./modules/node/content_types.inc and ./modules/node/node.module. It's works great but only when logged in as site admin. I used Override Node Options to enable content editors to use the Publishing options. But when I login as a content editor it still reads "Sticky at top of lists". How is this possible if I changed all instances in the scripts?
Should I start a new post on this issue?
#12
#13
It's been 1.5 years since Marco worked on this, think I can take over and close it out? :)
Patch Testing Instructions
This patch changes the label text of several things pertaining to making a node 'sticky'. There's five pages that this patch affects:
/admin/build/types/add/admin/content/node/node/1/editadmin/settings/search/admin/Simpletest
Now that I've written out all of these instructions, it's starting to look like a Simpletest might be in order? Holla if you want one, and I'll add it.
#14
Adding tags.
#15
The last submitted patch failed testing.
#16
Woops! Apparently, one cannot change the text of
function node_action_info() {'node_make_sticky_action' => array(
'type' => 'node',
'description' => t('Make post sticky'),
to add a (stays at top of content lists) clause without messing up the Triggers simpletest line of
// Test 3: The action should be able to be unassigned from a trigger.$this->assertRaw(t('Action %action has been unassigned.', array('%action' => ucfirst($info['name']))), t('Check to make sure the @action action can be unassigned from the trigger.', array('@action' => $info['name'])));
so we'll just go without that one because I don't want to rewrite triggers' tests tonight. :)
#17
I think it's unnecessary to write a test that accompanies the changes in this patch, since there are no functional changes introduced by this patch, only changes to texts wrapped in
t(). Further, we need to update the simpletest that failed so that it knows about the new text, not the other way around.Otherwise, this is great! :D
#18
When you change the text for the "make sticky" action, you may also want to change the text for the "make unsticky" action to match.
If this has been approved by the Usability Team, what else needs to happen for it to get in to 7.x?
#19
subscribing