Closed (duplicate)
Project:
Drupal.org security advisory coverage applications
Component:
module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
19 Apr 2013 at 14:33 UTC
Updated:
9 Sep 2018 at 23:46 UTC
Jump to comment: Most recent
Comments
Comment #0.0
dustin bons commentedCode tag
Comment #0.1
dustin bons commentedAdded benchmark
Comment #0.2
dustin bons commentedMore info
Comment #0.3
dustin bons commentedMore information
Comment #1
PA robot commentedThere are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxDustin1964166git
We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and we will take a look at your project right away :-)
Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #2
markpavlitski commentedYou've implemented hook_requirements(), however this is an install hook, so it should be defined in igbinary_cache.install rather than in your module file.
Can I also suggest you update your git details in the issue summary with the public details instead. You can find it on your sandbox version control page, if you check the 'Non-maintainer?' box.
Comment #2.0
markpavlitski commentedAdded a review
Comment #3
dustin bons commentedFixed some coding standards. Still got one warning in the README.txt but changing this one only makes it harder to understand.
Comment #4
PA robot commentedProject 1: http://drupal.org/node/1986148
Project 2: http://drupal.org/node/1974868
As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).
If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.
I'm a robot and this is an automated message from Project Applications Scraper.
Comment #4.0
PA robot commentedChanged git repo information to public
Comment #5
avpaderno