breaks when KB translation contains double quotes [#197612]

Working with IMCE translated to hebrew, the word 'KB' is translated to 'ק"ב' (notice the double quotes inside the string).

This breaks the code that inserts the image into the image selection window after selecting it in the image browser. see this comment and the two that follows.

The attached patch (against DRUPAL-5 branch) fixes this issue.

Comment	File	Size	Author
	imce_string_escape.patch	2.82 KB	yhager

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

ufku CreditAttribution: ufku commented 5 December 2007 at 04:38

thanks for the patch.
Is it possible that filenames contain this quote char?
If so we need to change the method for calling imceFinitor.
In the attached patch it is called with only the row index of the file and properties of the file is resolved inside imceFinitor. Moreover eval is no more used.
please try it. if you find any errors you're wellcome to submit another.
I will commit this soon.

Comment #2

liorkesos CreditAttribution: liorkesos commented 15 January 2008 at 09:22

Hi ufku,
Filenames could theoretically include the '"' but I think it's wise to address that scenario as well.
We could have a filename called תשובות מהע"וד and it could retrigger the bug.
This is important because we're manually changing the translation these days to overide the bug.
What needs to be done in order to commit the patch? Can we help in something?
Lior