Hi there!

I want to request becoming a co-maintainer for this module. My employer has assigned me to work on this module for customer projects and has contributed time towards that. I would help out with the issue queue and in general help maintain this module.

I must admit that I have not worked with this module on a code basis before, but I plan to dig through it in the next days.

I am a regular contributor to Drupal core and am very comfortable with the Drupal API, coding standards, etc. You can also look at my contrib work for reference.

I personally don't like to grant co-maintainership for my projects without having seen some patches or other work, so I won't ask you to do likewise. In case your not that familiar with my core work, maybe you could assign some issues to me that I could work on to prove myself.
Alternatively, we could also agree that for the time being I only push to dev branches and not the actual version branches. Whatever suits you best, I'd love to contribute!

Regards,
Tobias

Comments

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

AWESOME!

I'm very tempted to immediately give you full maintainership rights. Because as you can tell by the issue queue and the commit history, not much has been happening here. Far too little.

This is a module that triggers a lot of support requests. And — being honest — a lot of those support requests are very unreasonable, very poorly written, very hard to understand, and so on, because this module attracts so many newbie users.

However, the module's code can be quite tricky, in large part because Form API was never designed to support highly complex form elements like Hierarchical Select. It was definitely never designed for AJAXy form elements, which is what Hierarchical Select is.
So, in that light, I think it's better if at least initially, I review the patches before you commit them. I promise you a very short feedback loop — ping me on IRC/Twitter/e-mail, and I'll reply ASAP. Then, once I notice you need only very little feedback, you won't need my review/approval anymore. Does that sound good?

I've given you the "Write to VCS" and "Maintain issues" rights.

Please thank your employer for me :)

Can't wait to be pinged :)

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented

That sounds incredibly sensible. :-)
I'll keep you busy, then. :-P

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Yay :D :)

kars-t’s picture

kars-t commented

Hi

HS is really a "killer feature" for my company and I am really happy we can give the module some love :)

I will begin to clean up the issue queue. I have good experience with closing about 1.000 core, views and i18n "support" issues ;)

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

:D I also just saw your "Issue Helper" sandbox. Very cool!

kars-t’s picture

kars-t commented

Great you like it :)

Just to note:

Tobias is not gone but bound in a project of ours. So he will start later. I will tackel more issues and hope to speak to you in Portland.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented

Oh, great, you'll be in Portland! Yes, let's definitely meet :)

And no problem at all on the delay. I'm trying to chime in with cleaning up the issue queue — replied to a bunch of issues today :)

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Request for co-maintainership » Offering to co-maintain Hierarchical Select
Category: Task » Support request
Issue summary: View changes
Status: Active » Fixed

I am closing this issue, since tstoeckler has been added as co-maintainer.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.