[D7] JobFaucet

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxremydenton1972978git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi, remydenton.

Reviewed manually:

jobfaucet.admin.inc:

line 6 - grammatical mistake in comment.
line 142 - better use PDO instead db_query()
line 149 -

    $auth_description = t('To use JobFaucet, enter your JobFaucet public and private keys below.
      If you don\'t yet have an account, you can create one at <a href="http://jobfaucet.com">JobFaucet.com</a>.');

Don't use tags in t()

line 177 -

        '#description' => t('The content types you are using for jobs.  If you select types other than
      <em>JobFaucet Job</em>, you\'ll need to configure the mapping.'),

Don't use tags in t()

jobfaucet.module

line 348 -

      drupal_set_message(t("This job won't be sent to JobFaucet because the following required values are empty: @empty_fields.
        You may need to update the job or check your <a href='@mapping_page'>content type mapping</a>.",
        array('@empty_fields' => $empty_fields, '@mapping_page' => $mapping_page)), 'warning');

Don't use tags in t()

line 423 - what is unused $existing ?
function jobfaucet_theme($existing) {

line 466 -

    drupal_set_message(t('JobFaucet is in test mode.  If you are ready to syndicate your jobs, go to the
      <a href="@settings">settings</a> page to turn syndication on.', array('@settings' => $settings_url)), 'warning');

Don't use tags in t()

Links are often needed in t(), so that is not a problem.

db_query() should be used indtead of db_select() for simple static queries, that is also not a problem. See http://drupal.org/node/310075

Any other blockers?

Remy, sadly, we did not get together at Drupalcon to do a review of your module. I will take a look at this in the next week.

Thanks for your contribution, remydenton!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.