[D7] Commerce Taxonomy Conditions

First of all if you want a review, update the status to "needs review".

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hi redsd,

Few comments:
1. Make your own functions (not hook) on a different file.
2. vocabularie => vocabulary ;)

I haven't changed project status, but please fix #1.

Good luck!

It appears you are working in the "7.x-1.0" branch in git. This git branches do not match the release branch pattern.
So remove or rename this branch.

For additional resources please see the documentation about release naming conventions and creating a branch in git.

First set default branch 7.0-1.x
then checkout 7.0-1.x branch
after
Mighte be
git branch -D 7.0-1.0 this will help you

Please fix the warnings in http://ventral.org/pareview/httpgitdrupalorgsandboxredsd1926096git.

Hi

PAReview scripts did not find any issues, that's good.

This module definitely needs more pretty project page :) Please take a moment to make your project page follow tips for a great project page. You can add a link to the simplytest.me page for testing purposes instead of giving a URL for downloading ZIP-archive with the module.

Manual review, minor issues:

• There's a directory '1926096' in the repo.. It seems that it is not needed.
• Function commerce_taxonomy_conditions_term_options_list(), line 106: it is not neccessary to set a first option for select element manually, you can use '#empty_option' parameter instead, see D7 Form API

I didn't managed to find other issues, your code is pretty nice.

Good luck

Check the link to GIT repo.

give the ability to change the effect from UI (I hate fade :) )

$form['parameter']['term_field_names']['settings']['term_field_names']['#ajax'] = array(
      'callback' => 'commerce_taxonomy_conditions_term_options_list_form',
      'wrapper' => 'term-ids-replacement',
      'method' => 'replace',
      'effect' => 'fade',
    );

Module looks nice, no problems or security issues found.

----
Top Shelf Modules - Enterprise modules from the community for the community.

I guess my main question is why would I want to hook up shipping costs to taxonomy terms? Could you add something about that to your project page? Your implementation seems fine though, using rules is the preferred Commerce method. Do you need to implement all the operands? Using greater or less than with a tid doesn't seem very useful.

Thanks for your contribution, redsd!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.