[D7] Webform Advanced Reports

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: http://drupal.org/node/1978434

Project 2: http://drupal.org/node/1985214

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: http://drupal.org/node/1978434

Project 2: http://drupal.org/node/1985214

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

@hiryu: no, please open only one project application. Once the first application has been successfully approved, then the applicant can promote other projects without review.

Multiple Applications

It appears that there have been multiple project applications opened under your username:

Project 1: https://drupal.org/node/1985214

Project 2: https://drupal.org/node/1978434

As successful completion of the project application process results in the applicant being granted the 'Create Full Projects' permission, there is no need to take multiple applications through the process. Once the first application has been successfully approved, then the applicant can promote other projects without review. Because of this, posting multiple applications is not necessary, and results in additional workload for reviewers ... which in turn results in longer wait times for everyone in the queue. With this in mind, your secondary applications have been marked as 'closed(duplicate)', with only one application left open (chosen at random).

If you prefer that we proceed through this review process with a different application than the one which was left open, then feel free to close the 'open' application as a duplicate, and re-open one of the project applications which had been closed.

I'm a robot and this is an automated message from Project Applications Scraper.

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxhiryu1985184git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Hey hiryu,

Now you've had your first project approved (the Auto Tag one) you don't need to have future projects reviewed, you can promote this project without others having to approve it first.

Hope that clears it up :)

Starting review...

Hi @hiryu

http://pareview.sh/pareview/httpgitdrupalorgsandboxhiryu1985184git

1. Project Page and Documentation
https://drupal.org/sandbox/hiryu/1985184
Improve the project page to clearly show installation and setup steps, perhaps some clearer headers. So a user who doesn't know what it is or why it's valuable can easily follow some step by step instructions and see what it does.

2. PAReview: 3rd party code
class DOMi appears to be 3rd party code. 3rd party code is not generally allowed on Drupal.org and should be deleted. This policy is described in the getting involved handbook. It also appears in the terms and conditions you agreed to when you signed up for Git access, which you may want to re-read, to be sure you're not violating other terms.
The Libraries API module is a recommended method for adding 3rd party dependencies without directly including the code on Drupal.org.

See below for an example of how to work with a third party library from devel.module

/**
 * Implementation of hook_init().
 */
function devel_init() {
  if (!devel_silent()) {
    if (user_access('access devel information')) {
      devel_set_handler(devel_get_handlers());
      // We want to include the class early so that anyone may call krumo() as needed. See http://krumo.sourceforge.net/
      has_krumo();

      // See http://www.firephp.org/HQ/Install.htm
      $path = NULL;
      if (@include_once('fb.php')) {
        // FirePHPCore is in include_path. Probably a PEAR installation.
        $path = '';
      }
      elseif (module_exists('libraries')) {
        // Support Libraries API - http://drupal.org/project/libraries
        $firephp_path = libraries_get_path('FirePHPCore');
        $firephp_path = ($firephp_path ? $firephp_path . '/lib/FirePHPCore/' : '');
        $chromephp_path = libraries_get_path('chromephp');
      }
      else {
        $firephp_path = './' . drupal_get_path('module', 'devel') . '/FirePHPCore/lib/FirePHPCore/';
        $chromephp_path = './' . drupal_get_path('module', 'devel') . '/chromephp';
      }

      // Include FirePHP if it exists.
      if (!empty($firephp_path) && file_exists($firephp_path . 'fb.php')) {
        include_once $firephp_path . 'fb.php';
        include_once $firephp_path . 'FirePHP.class.php';
      }

      // Include ChromePHP if it exists.
      if (!empty($chromephp_path) && file_exists($chromephp_path .= '/ChromePhp.php')) {
        include_once $chromephp_path;
      }

3. Constants

define('WEBFORM_ADVANCED_REPORT_MODULE_TITLE', 'Webform Advanced Report');
define('WEBFORM_ADVANCED_REPORT_PATH_NAME', 'webform_advanced_report');

/**
 * Implements hook_init().
 */
function webform_advanced_report_init() {
  // Adding CSS and JS just in the admin section.
  if (path_is_admin(current_path())) {
    drupal_add_css(drupal_get_path('module', WEBFORM_ADVANCED_REPORT_PATH_NAME) . '/' . WEBFORM_ADVANCED_REPORT_PATH_NAME . '.css', array('group' => CSS_DEFAULT, 'every_page' => TRUE));
    drupal_add_js(drupal_get_path('module', WEBFORM_ADVANCED_REPORT_PATH_NAME) . '/' . WEBFORM_ADVANCED_REPORT_PATH_NAME . '.js', array('group' => JS_DEFAULT, 'every_page' => TRUE));
  }

I don't see why WEBFORM_ADVANCED_REPORT_MODULE_TITLE and WEBFORM_ADVANCED_REPORT_PATH_NAME are necessary. Nor is this an approach generally used by other modules. Just use the text itself.

3. Database API & Security

/**
 * Retriving all content types.
 */
function webform_advanced_report_sid_date_range($date_start = WEBFORM_ADVANCED_REPORT_DEFAULT_START_DATE, $date_end = WEBFORM_ADVANCED_REPORT_DEFAULT_END_DATE) {
  // Select submitted nids.
  $nids = variable_get('webform_advanced_report_user_nids');
  if (empty($nids)) {
    return FALSE;
  }

  // Search for relative sids.
  $sql_nids = '(';
  foreach ($nids as $nid) {
    $sql_nids .= ' nid = ' . $nid . ' OR';
  }
  $sql_nids = substr($sql_nids, 0, strrpos($sql_nids, " ")) . ")";

  // Date pattern: 'Y-m-d H:i'.
  $sql = "
    SELECT
      webform_submissions.sid
    FROM
      webform_submissions
    WHERE FROM_UNIXTIME(submitted, '%Y-%m-%d %H:%i') BETWEEN '" . $date_start . "' AND '" . $date_end . "'
      AND " . $sql_nids . "
  ";
  $results = db_query($sql)->fetchAll();

  return $results;
}

This is a security risk and not the standard way to use the db api. See https://drupal.org/writing-secure-code and https://drupal.org/node/310069
You need to fix this in all places you make database queries.

There are lots of other things, but fix those 3 things and try again, you will have made a big step forward and someone can do the next review for you to get it release quality.

Already Approved

It appears that you have successfully completed the application process with a different application, and been granted the 'create full projects' permission:

Project: https://drupal.org/node/1978434

Once their first application has been successfully approved, then an applicant can promote other projects without review. Because of this, posting multiple applications are not necessary, and results in additional workload for reviewers!

Instead, you can post to the Peer Review group for feedback, here:

https://groups.drupal.org/peer-review/about

With this in mind, I have marked your application as 'closed(duplicate)'. If this is incorrect, and you do not yet have the ability to create full projects, then please feel free to re-open this application.

----
Top Shelf Modules - Crafted, Curated, Contributed.

updated description