[D7] PDFTK

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Manual review
1) add git clone string into project description
2) Use $path = libraries_get_path('library_name'); to get library path instead of $slibrary = 'sites/all/libraries/php-pdtfk-toolkit-master/pdftk/pdftk.php';. Read this article
3) don't hardcode 'public://'' or private files storage. $ofile = file_save_data($oimage, 'public://' . $stmpfilename, FILE_EXISTS_RENAME); use file_default_scheme() instead

Hi,

In drupal 6 I, created the pdf merger module sandbox project..(With help of fpdi and fpdf library)

Please refer this link to know more

http://drupal.org/node/1984222

Just check this and give your feedback ..

Regards,
-Raj.

Changed required library version

Hi Linwiz,

Thanks for your reply. Already I reviewed my code through the automated review and coder module. It does not has any error.

Updated summary with relevant information.

Review of the 7.x-1.x branch:

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  FILE: /home/klausi/pareview_temp/pdftk.install
  --------------------------------------------------------------------------------
  FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
  --------------------------------------------------------------------------------
   119 | ERROR | No space found after comma in function call
  --------------------------------------------------------------------------------
  

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. pdftk_enable(): use variable_get('user_admin_role') instead.
2. "watchdog('PDFTK', "PDFTK will not run for node $node->nid because the requirements have not been met. Check the Status report for more information.", NULL, WATCHDOG_ERROR);": do not concatenate variables into translatable strings, use placeholders with the watchdog message instead.
3. pdftk_node_insert(): why do you implement a node hook and not hook_entity_insert() so that the field can work on any entity type?
4. Why do you need cron? Does the operation take so long? I would suggest to use the batch API instead if you have many documents that you want to merge.
5. I would write this module differently: Add a field instance setting (checkbox) to file fields to enable merging within the field. Implement entity insert/update hooks, check if the setting is present in the field info for file fields, check if the field has multiple files, merge the files together (maybe batched or queued), replace the first field item with the merge file, remove the other field items and delete the now obsolete files. That way you don't have to hard-code any field name.
6. pdftk_permission(): the admin permission is never used?

Although you should definitively look into those issue they are not critical application blockers, so I guess this is RTBC. Removing review bonus tag, you can add it again if you have done another 3 reviews of other projects.

Assigning to cubeinspire as he might have time to tkae a final look at this.

You can just iterate over all fields and check their type with field_info_fields() or a similar function. Supporting other entity types is a good idea, since you may want to stick fields on users, terms, commerce products, profiles etc.

No objections for more than a week, so ...

Thanks for your contribution, linwiz!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.