Number of takes was not working as intended, I have moved it into a more correct place to fix this issue, heres is patch.

CommentFileSizeAuthor
#5 quiz_number_of_takes.patch1.85 KBwestwesterson
#1 quiz_numberoftakes.patch1.97 KBwestwesterson
quiz_numberoftakes_0.patch2.01 KBkylebrowning

Comments

westwesterson’s picture

westwesterson commented
Status: Needs review » Needs work
StatusFileSize
new quiz_numberoftakes.patch1.97 KB

I have upgraded this patch to the current head, but it does not work as supposed to. It makes the quiz unavailable for non -admin users.

kylebrowning’s picture

kylebrowning commented

I wonder why, looking into it.

awong’s picture

awong commented

I think this issue related to http://drupal.org/node/193840
I think that patch submitted there fix the error.

senpai’s picture

senpai commented

I see the patch at /node/193840 has been committed. Does that mean this particular issue is also resolved? Does osyrus' quiz_numberoftakes.patch work as intended now?

westwesterson’s picture

westwesterson commented
Status: Needs work » Needs review
StatusFileSize
new quiz_number_of_takes.patch1.85 KB

i have rerolled this patch for testing against latest in HEAD.

westwesterson’s picture

westwesterson commented
Status: Needs review » Fixed

this now works as expected, thanks!

senpai’s picture

senpai commented

Yeah, it was trying to remove the same piece of code as the afore-mentioned patch by awong. Thanks for re-rolling. I was re-rolling that at the same time you were, then I saw your commit message. Cool!

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

  • Commit 4a7b150 on 5.x-2.x, 6.x-2.x, 6.x-3.x, 6.x-4.x, 6.x-5.x, 6.x-6.x, 7.x-4.x, master, 7.x-5.x by westwesterson: 
    Number of takes was not working as intended Issue #198848 by ocyrus

  • Commit 4a7b150 on 5.x-2.x, 6.x-2.x, 6.x-3.x, 6.x-4.x, 6.x-5.x, 6.x-6.x, 7.x-4.x, master, 7.x-5.x, quiz-pages by westwesterson: 
    Number of takes was not working as intended Issue #198848 by ocyrus

  • Commit 4a7b150 on 5.x-2.x, 6.x-2.x, 6.x-3.x, 6.x-4.x, 6.x-5.x, 6.x-6.x, 7.x-4.x, master, 7.x-5.x, quiz-pages, 2269219 by westwesterson: 
    Number of takes was not working as intended Issue #198848 by ocyrus

  • Commit 4a7b150 on 5.x-2.x, 6.x-2.x, 6.x-3.x, 6.x-4.x, 6.x-5.x, 6.x-6.x, 7.x-4.x, master, 7.x-5.x, 2269219 by westwesterson: 
    Number of takes was not working as intended Issue #198848 by ocyrus