Needs work
Project:
Internationalization
Version:
7.x-1.x-dev
Component:
Taxonomy
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
8 May 2013 at 17:04 UTC
Updated:
25 Apr 2015 at 11:40 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
vincenzo commentedA possible viable patch attached.
Comment #2
vincenzo commentedI had forgotten the comment for the
hook_permissionsin the previous one.Comment #3
vincenzo commentedComment #4
dublin drupaller commented#2 looks good Vincenzo. recommend we get this in asap.
Comment #5
pbz1912 commentedAll good for me and a really needed idea.
Comment #6
anouPatch is "wrong" :
should be :
And it doesn't works with "Localize" terms... Sorry I didn't test it with "Translate" terms
Comment #7
anouComment #8
dublin drupaller commentedamended patch attached.
Comment #10
Encarte commentedComment #11
Encarte commentedComment #13
Encarte commentedSeems there were some changes on dev, but this patch is working against the 7.x-1.8 release (tested the "Translate" option).
Comment #14
vincenzo commentedI'll try and fix/update this patch ASAP. I will do it against -dev.
Comment #15
vincenzo commentedI've just been working on this, and I have the feeling the patch was failing the test just because the latest files were corrupted.
At least, that's what I got. I took the latest patch from Encarte and couldn't apply, git-apply was coming back with this error
Therefore I recreated it, and after that the patch applied cleanly against -dev.
Let's hope I am right.
Here we go.
Comment #16
vincenzo commentedComment #17
jose reyero commentedThis may make some sense but not only for taxonomies but for any other object (menu items, blocks...) so at this point it will create more inconsistencies than we have actually.
On the other side, existing permissions are more consistent with the 'interface translation' pages, where you can translate all kind of strings.
So existing permissions may be conceptually wrong but this won't get them any better, and unless we really fix all these permissions I don't think adding a new one will actually improve anything. It will just break permissions for existing working sites.
Comment #18
robloachMight actually be better to take them on one at a time. Then the patch and diff won't be huge and unmaintainable.
In other news, I found a few additional changes to help make this work. Note that tests fails with or without the patch, and taxonomy translation is inherited from string translation.
Comment #20
jose reyero commented