This module provides a simple Teamspeak 3 server web viewer rendered into a block
The module it's compatible only with Drupal 7.x core: No Drupal 6 version will be implemented since there are already other modules that offer the same functionality and which are compatible with Drupal 6.x core. A version of this module compatible with Drupal 8 will be released as soon as Drupal 8 will become the new stable version of Drupal.

Core: Drupal 7
Project: http://drupal.org/sandbox/FenixXx/1992708
Repo: git clone --branch master FenixXx@git.drupal.org:sandbox/FenixXx/1992708.git

CommentFileSizeAuthor
#5 teamspeak3-module.png70.15 KBhardcoding

Comments

danielepantaleone’s picture

danielepantaleone commented
Status: Active » Needs review
PA robot’s picture

PA robot commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://ventral.org/pareview/httpgitdrupalorgsandboxFenixXx1992708git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

danielepantaleone’s picture

danielepantaleone commented
Status: Needs work » Needs review

Fixed all the issues listed

yandex-plugins’s picture

yandex-plugins commented

Hello,

checked your module dir structure. You need move files from teamspeak3 to root of your project. It's no sense to place all code in subfolder.

Regards

hardcoding’s picture

hardcoding commented
Status: Needs review » Needs work
StatusFileSize
new teamspeak3-module.png70.15 KB

Hi FenixXx,

first of all i searched a long time for such a module. Drupal really needs this.

So i tested your module and i found some bugs.

After installing i wanted to click the configuration link on module page, but there is no link. Would you be so kind to add one?

On your configuration page there is an authentication tab with username and password. The input field for password is shown in plain text. Can you hide it?

When i integrated your block i saw that you created a cache file. Isn't it easier to use variable_set() for this? With that solution you won't have problems with file permissions.

To your block: You have some Problems with characters. I made a screenshot so you can see the problem.

To your files: Can you move your file folder one level higher? After cloning your module i had this structure:
../teamspeak3/teamspeak3/teamspeak3.module
this structure would be better:
../teamspeak3/teamspeak3.module

All in all a really nice module. Can't wait to integrate it on my website.

hardcoding’s picture

hardcoding commented

#5

in my file there must be written tsviewer.com instead of teamviewer.com :)

danielepantaleone’s picture

danielepantaleone commented

Hello everyone and thanks for the feedback. It's my 1st Drupal module, so please understand if sometime I fail ^_^
Anyway I'm going to fix the char display bug and to apport all the modifications suggested

danielepantaleone’s picture

danielepantaleone commented
Status: Needs work » Needs review

Applied changes:

  • Moved project files into module root
  • Added configure button
  • Fixed special characters display bug
  • Changed cache system (uses variable_set now)

I left the serverquery password field as textfield, otherwise everytime you need to edit the module settings, you will need to type the password again

EDIT: I moved the module into "Other" module section

hardcoding’s picture

hardcoding commented

Couldn't you put the authentication settings in a separate tab? So that you have another form. Imho there should be no problems with that.

My problem with plain text is, that other user can actually see your authentication settings.

danielepantaleone’s picture

danielepantaleone commented

I applied the requested changes

danielepantaleone’s picture

danielepantaleone commented

Committed some changes:

  • Use REQUEST_TIME instead of PHP time() function
  • Changed module package to "Gaming" (same group shown in admin/config)
  • Added missing line-height proprierty in teamspeak3.css
tmctighe’s picture

tmctighe commented
Status: Needs review » Reviewed & tested by the community

FenixXx,

Overall your module looks solid. The module definitely clashes with the already existing ts3 project in terms of accomplishing the same thing. Have you attempted to contact the maintainer of that module? If possible it would be best to bring these two projects together, especially since they are different drupal versions.

It generally fits more of Drupal's standards to use Watchdog as opposed to just throwing exceptions.

Also, it is highly recommended to make a better project page (http://drupal.org/node/997024) and better information in the README.

You have no major blocking problems and it looks safe so I'm marking RTBC.

danielepantaleone’s picture

danielepantaleone commented

I spoke with the guy who created the Teamspeak 3 module for Drupal 6.x. He proposed me to merge the 2 projects into a single one (under the name Teamspeak) since both the modules do the same job.

mlncn’s picture

mlncn commented
Status: Reviewed & tested by the community » Fixed

Thanks for your contribution, FenixXx! You are now a vetted Git user. Please do get added as a maintainer to the TS3 project and make this the D7 branch, but you'll also be able to make projects you create either a sandbox or upgrade them yourself to a full project. (As tmctighe notes you'll need a vastly more complete project page!)

Here are some other recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and stay involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

And thanks to the awesome reviewers, including tmctighe and hardcoding!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.