Tableselect "select all" checkbox should be checked on page load if all checkboxes are ticked

This problem exists in Drupal 8, too, so it should be fixed there, too. Here's a reroll of the patch, consistent with our coding standards for d8.

Patch no longer applies.

Thanks, @jhedstrom. Here's a reroll.

I was going to manually test this, but realized I can't think of a place in core where all the checkboxes would be checked by default. The ones I'm aware of are operation-based (user admin, content admin, term admin, etc), meaning the checkbox state doesn't persist between visits to the page.

Thoughts on how to test?

Well, this is probably the weirdest possible way to do this, but the attached patch will cause all checkboxes to render checked off except those in a table header. Thus any listing you view will have all the items checked off, but the summary checkboxes won't be affected on the server side. The People page at admin/people is a good page to test with. If you apply this patch and view that page, you'll see all the users checked off, but the header checkbox won't be checked. If you then apply the real patch in #4 and revisit the page (making sure you've disabled JS aggregation or cleared cache), you should see all the users checked off and the header checkbox.

I manually tested this using the patch in #7 and it works as expected. Even though this isn't directly used anywhere in core, it is a win for contrib that utilizes the tableselect functionality.

I've updated the summary with a beta-phase evaluation.

Thanks, @jhedstrom!

+++ b/core/misc/tableselect.js
@@ -60,6 +60,10 @@
+    // If all checkboxes are checked on page load, make sure the select-all one is
+    // checked too, otherwise keep unchecked.

Breaks our 80 character comment limit

D'oh! Thanks, @alexpott.

Moving back to RTBC now that the testbot approves, since it was just a comment line length change.

The issue summary calls this a feature, but I'd classify it as a small UX bug, and that's what the issue is classified as, as well (fixed that). Because it's a bug fix with no other disruption, it's allowed by https://www.drupal.org/contribute/core/beta-changes.

Committed and pushed to 8.0.x. Thanks!

Original bug was against Drupal 7, lets backport this patch. Patch at #1 needs at least a comment length change.

I tested it on the latest D7 by visiting the admin/content page, selecting all nodes using the "select all" checkbox and then refreshing the page. Before applying the patch all nodes was selected after the refresh but the "select all" checkbox remained unselected. After applying the patch, all nodes are selected and the "select all" checkbox is selected also.
I think this patch is ready to be integrated in D7.

Reset the status has last Simpletest failure was a false positive.

Testbot fluke.

Committed to 7.x - thanks!