On line 180 in tour.js we have the following line:

if ((itemId || itemClass) && $document.find('#' + itemId + ', .' + itemClass).length === 0) {

If "itemClass" or "itemId" are not provided we end up with something like "#, .foo" or "#foo, ." we need to check these individually.

CommentFileSizeAuthor
#7 1995152-7-broken-selector.patch642 bytesnick_schuch
#4 1995152-4-broken-selector.interdiff.txt642 bytesnick_schuch
#4 1995152-4-broken-selector.patch827 bytesnick_schuch
#2 1995152-1-broken-selector.patch866 bytesnick_schuch

Comments

nod_’s picture

nod_
Primary language French
Location Lille
commented
Issue tags: +JavaScript

tag

nick_schuch’s picture

nick_schuch commented
Status: Active » Needs review
StatusFileSize
new 1995152-1-broken-selector.patch866 bytes

I have refreshed the logic to look for the itemId and/or itemClass first before checking the page.

nod_’s picture

nod_
Primary language French
Location Lille
commented

I don't think we need the first line.

nick_schuch’s picture

nick_schuch commented
StatusFileSize
new 1995152-4-broken-selector.patch827 bytes
new 1995152-4-broken-selector.interdiff.txt642 bytes

Right you are! Cheers!

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs review » Reviewed & tested by the community
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 5a60cba and pushed to 8.x. Thanks!

nick_schuch’s picture

nick_schuch commented
Status: Fixed » Needs review
StatusFileSize
new 1995152-7-broken-selector.patch642 bytes

This broke modal's. I must have had cache js while testing. :(

nod_’s picture

nod_
Primary language French
Location Lille
commented

ok the condition looks better like that.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Issue tags: +Needs manual testing, +Needs JavaScript testing

tag for sprint :)

nick_schuch’s picture

nick_schuch commented

Some steps to test #7:

1) Apply the patch in #7.
2) Apply the forum tour patch: https://drupal.org/node/1926296#comment-7445882
3) Enable the forum module.
4) Go to the "Add container" form for forum.
5) Start the tour. The first tip you should see if the a modal tip.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quick fix

Lets get this in

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed ae1116d and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Update description.