[D7] Style Manager

good to see fixed errors http://drupal.org/node/608152#naming

ILE: ...al-7-pareview/pareview_temp/includes/style_manager.context_reaction.inc
--------------------------------------------------------------------------------
FOUND 4 ERROR(S) AFFECTING 3 LINE(S)
--------------------------------------------------------------------------------
11 | ERROR | Class name must begin with a capital letter
11 | ERROR | Class name must use UpperCamel naming without underscores
15 | ERROR | Public method name "style_manager_reaction_preset::options_form"
| | is not in lowerCamel format, it must not contain underscores
42 | ERROR | Public method name
| | "style_manager_reaction_preset::options_form_submit" is not in
| | lowerCamel format, it must not contain underscores
--------------------------------------------------------------------------------

and code styling http://drupal.org/node/172169

ILE: /var/www/drupal-7-pareview/pareview_temp/js/jscolor/jscolor.js
--------------------------------------------------------------------------------
FOUND 8 ERROR(S) AFFECTING 4 LINE(S)
--------------------------------------------------------------------------------
857 | ERROR | Expected 1 space after "<"; 0 found
857 | ERROR | Expected 1 space before "<"; 0 found
858 | ERROR | Expected 1 space after "<"; 0 found
858 | ERROR | Expected 1 space before "<"; 0 found
859 | ERROR | Expected 1 space after "<"; 0 found
859 | ERROR | Expected 1 space before "<"; 0 found
860 | ERROR | Expected 1 space after "<"; 0 found
860 | ERROR | Expected 1 space before "<"; 0 found
--------------------------------------------------------------------------------

looks like #2 good for me
Impressive work!!
Vote for project push from sandbox

PS.
Good to see first issues in feature project - test coverage and Drupal 8 roadmap!

Sorry for the delay, but you have not listed any reviews of other project applications in your issue summary as strongly recommended in the application documentation.

There is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732
Review of the 7.x-1.x branch:

• Coder Sniffer has found some issues with your code (please check the Drupal coding standards).
  

  FILE: /home/klausi/pareview_temp/style_manager.module
  --------------------------------------------------------------------------------
  FOUND 0 ERROR(S) AND 3 WARNING(S) AFFECTING 3 LINE(S)
  --------------------------------------------------------------------------------
   591 | WARNING | Do not pass empty strings to t()
   603 | WARNING | Do not pass empty strings to t()
   613 | WARNING | Do not pass empty strings to t()
  --------------------------------------------------------------------------------
  

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. jscolor.js: appears to be 3rd party code. 3rd party code is not generally allowed on Drupal.org and should be deleted. This policy is described in the getting involved handbook. It also appears in the terms and conditions you agreed to when you signed up for Git access, which you may want to re-read, to be sure you're not violating other terms. The Libraries API module is a recommended method for adding 3rd party dependencies without directly including the code on Drupal.org.
2. API.txt: this should be a *.api.php file, see https://drupal.org/node/161085#api_php
3. README.md: empty file, so remove it?
4. style_manager_check_token(): why can't you use drupal_valid_token()? Please add a comment.
5. style_manager_get_token(): if there is a session then the page is not cacheable anyway, since Drupal caches pages for anonymous users only.
6. style_manager_init(): looks quite heavy performance-wise. Add a not to the project page that this should never be run on a production site?
7. style_manager_get_token(): this has no security benefit - if I know the time then I can also re-create the security token. Please use drupal token system with drupal_get_token().
8. "Implements of hook_style_manager_widgets()." should be "Implements hook_style_manager_widgets().". Also elsewhere.
9. style_manager_check_token(): the access callback ignores the access arguments which look like a user permission? Which means all your menu paths are unprotected, so this is an access bypass security issue. And please don't remove the security tag, we keep that for statistics and to show examples of security problems.

Closing due to lack of activity. Feel free to reopen if you are still working on this application (see also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.

add code review