Duplicate fields in CSV template [#1996240]

Sometimes, there is the need to assign the same field of the input csv file to different drupal fields. Take for example the attached image. This works ok.
The problem is with the 'download template' functionality. This field appears twice, in the template. It should appear only once.

Comment	File	Size	Author
#4	feeds-duplicate-in-csv-template-1996240-4.patch	1.07 KB	msti
#3	feeds-duplicate-in-csv-template-1996240-3.patch	680 bytes	megachriz
#1	feeds-duplicate-in-template-1996240-1.patch	845 bytes	msti
	User Import.png	59.66 KB	msti

Comments

Comment #1

msti

Heraklion

commented 16 May 2013 at 12:02

Status:

Active

» Needs review

Status	File	Size
new	feeds-duplicate-in-template-1996240-1.patch	845 bytes

This patch fixes the problem described above.

Comment #2

megachriz

Dutch

commented 16 May 2013 at 12:15

It took me a few seconds before I understood what you meant with 'download template'.

Here are the steps to reproduce the error:

To reproduce the issue:

Create an importer with a CSV parser.
Add two mappers using the same source field, for example:
```
email > Email address
email > User name
```
Go to /import and select the importer you created.
Click on the link "Download a template" (import/myimporter/template).

Actual result:

email,email

Expected result:

email

Comment #3

megachriz

Dutch

commented 16 May 2013 at 12:48

Status	File	Size
new	feeds-duplicate-in-csv-template-1996240-3.patch	680 bytes

I can confirm the patch in #1 fixes the bug: after applying the patch, I get each column only once in the template.

The patch has some minor coding style issues though: after a comma should come a space:
+ elseif (!in_array(check_plain($mapping['source']),$sources) && !in_array(check_plain($mapping['source']),$uniques)){No space before $sources, $uniques and {

+ elseif (!in_array(check_plain($mapping['source']), $sources) && !in_array(check_plain($mapping['source']), $uniques)) {Spaces included

Also, I think it makes the code more readable if the check for existing columns is done once. The attached patch first does a check for existing columns before deciding whether the column should be added to $uniques or $sources.

Comment #4

msti

Heraklion

commented 30 May 2013 at 23:17

Status	File	Size
new	feeds-duplicate-in-csv-template-1996240-4.patch	1.07 KB

This patch fixes an related:

Just above the 'Download a template' link, there is a list of the fields that show in the csv file. This list also contains duplicates.
This patch removes the duplicates.