Convert pre-existing filenames

I've created a newer issue for this, for the newer module, over at http://drupal.org/node/202884.

Transliteration 6.x-1.0+ does this. So, not having looked at your code, perhaps you could look at the code in the 6.x branch and see if it is backportable?

I doubt I'll get a chance to do this. Perhaps someone else can take this and run with it?

The .install file from the DRUPAL-6--1 branch is now a part of DRUPAL-5--2, the upcoming 2.0 release.

Automatically closed -- issue fixed for two weeks with no activity.

I'm lucky that I've read the changelog prior installing Transliteration on an existing site. While this feature makes sense, it has the possibility of breaking existing download URLs in contents or links on external sites. That is why the original patch implemented a confirmation form that warns the user about possible implications of this action.

IMHO, this should really be an opt-in feature. Maybe a constant in the .install file.

I agree with Sun, this should really be an opt-in feature. Maybe a constant in the .install file or button on a settings page.

I had the same problem. If you got inline images, this can be downright dangerous.

Loads of images can vanish. Please make the retroactive conversion optional.

I just had a whole bunch of file attachment links on my site break because files were retroactively renamed. :( At minimum, this needs to be mentioned in the Readme, and ideally a warning should be presented before the conversion of pre-existing file names takes place. It would be better to have this as an option, however.

I suppose there's no going back now. I didn't notice the problem on the same day as I installed this module, so we'd lose too much data by reverting to a backup.

Could a utility be developed to sanitize URLs within nodes, to help us recover?

Changed the status to critical - because this may cause people serious trouble. Imagine someone having several thousand files, and a fith is erroneuosly converted.

There is also a problem with imagefield - imagefield creates .thumb.jpg files in the D6 version for the preview thumbnails in the upload widget. Snce these files are not in the files table, their names are not transliterated. But since Imagefield appears to create the name it looks for from the original filename, it cannot find those files anymore - in consequence all the widgets are there but no thumb images anymore, if the file name was transliterated.

It looks like the modules "scanner", "node find replace" and "search and replace" may be able to go through and fix the broken links, but I need to know what all the "sanitized" substitutions were.

This burned me as well. In my case I enabled the module on a production site, thinking it would clean up new file uploads, and it managed to change filepaths on a bunch of my files without updating the records in the files table. (This particular anomaly was probably related to my use of private_upload module). To fix it I ran

to get rid of the spaces left in the files table that didn't match the new filepaths.