Timeago Patch Breaks functionality [#1996706]

As ezra_g pointed out in #1925208: Use drupal_http_request for determining version information The timeago functionality has changed. I've been tracking down the issue and it's that the modules timeago.js file isn't loaded. I think you removed this out of error thinking it's a duplicate js file but in reality it's a helper file for the timeago module to initiate it's functionality. Please remove this patch from the make file.

I recommend rolling back the next update to include the non-patched version of the module.

Edit: Forgot to add the two lines in question that'll bring back the functionality, after line 356 add the following to profiles/commons/modules/contrib/timeago/timeago.module

    $path = drupal_get_path('module', 'timeago') . '/timeago.js';
    drupal_add_js($path);

Comment	File	Size	Author
#6	stock_commons.png	447.79 KB	devin carlson
#6	patch_removed.png	450.09 KB	devin carlson
#5	remove-timeago-patch-1996706-5.patch	633 bytes	devin carlson
#1	Clipboard01.jpg	22.89 KB	moheshmohan

Comments

Comment #1

moheshmohan commented 28 May 2013 at 20:01

Issue tags:

+span class, +anchors not working, +Commons 7.x-3.2 radar, +Theme issue

Status	File	Size
new	Clipboard01.jpg	22.89 KB

wow this exactly solved the issue.... thanks mate... I have another problem and i could not solve it by myself...

Please look at the screen shot

I am using commons 3.2.

Some how the span inside anchor tags get displayed, this happens in multiple places (for example in users notification settings page etc). Similar issue was reported in http://drupal.org/node/1838928

So i thought its somehow related to timeago (thanks to my poor knowledge in coding)

Any ideas to fix this.... Thanks in advance :)

Comment #2

cellar door commented 29 May 2013 at 16:06

Sorry I can't tell what the issue is from your screenshot but I'm not guessing it's related to the timeago fix as it's doing it on non-time aspects. Best to open a new issue for that

Comment #3

ezra-g commented 29 May 2013 at 16:06

Issue tags:

-span class, -anchors not working, -Commons 7.x-3.2 radar, -Theme issue

+Commons 7.x-3.3 radar

Moving from 3.2 to 3.3 radar.

Comment #4

moheshmohan commented 29 May 2013 at 18:52

yep i opened another issue.... i guess its not related to timeago patch.. with or without it the issue is still on

Comment #5

devin carlson commented 30 May 2013 at 12:21

Assigned:	Unassigned	» devin carlson
Status:	Active	» Needs review

Status	File	Size
new	remove-timeago-patch-1996706-5.patch	633 bytes

As the original post points out, the patch currently applied to the Timeago module removes the inclusion of the module's initialization JavaScript.

The attached patch removes the patch against Timeago.

Comment #6

devin carlson commented 30 May 2013 at 18:10

Status:

Needs review

» Reviewed & tested by the community

Status	File	Size
new	patch_removed.png	450.09 KB
new	stock_commons.png	447.79 KB

Two screenshots demonstrating that the patch currently included in the Commons makefile prevents the Timeago JavaScript from loading: one after a fresh install of common and one after a fresh install of Commons with the patch removed.

Stock Commons