Allow Call Time Pass Reference Error

remove op_video_update_1() from op_video.install

This has now been fixed in 5.x-3.x-dev

Automatically closed -- issue fixed for two weeks with no activity.

Unfortunatelly when I upgraded to 5.x-3.x-dev module doesn't seem to work. When I go to configure I don't see most of the sections as in version 2.
There is no:
Video content
Thumbnail settings
Player settings
Transcoding parameters

Only "ffmpeg installation" and "OpenPackage.biz credentials" sections are present. Only in version 2.2 all these config sections are present. I had to uninstall 3.x-dev version of op_video and go back to older stable version and remove op_video_update_1() function from op_video.install in order to get rid of "deprecated" message.
.......................
Ok, later I was able to figure out (as jbrown already told) that I had to create new content type and add a field of type 'op_video'. After I did that, new content type automatically displayed "Preview Image", "Player", "Transcoding parameters".

This component (v.3) works well if you have your file system set to Public, but still didn't work when I switched to Private. I guess for v.3 this wasn't implemented yet.

There is no node type in 5.x-3.x, only the field type.

Same problem here. i tried tu upgrade to 5.x-3 but did not work and reinstalled the older version.
What exactly do I need to delete here "remove op_video_update_1() from op_video.install"?

Only this line

"function op_video_update_1() { // 2.1"

or the whole code block:

function op_video_update_1() { // 2.1

switch($GLOBALS['db_type']) {
case 'mysql':
case 'mysqli':

$ret[] = update_sql("
ALTER TABLE {op_videos}
CHANGE duration duration INT(10) UNSIGNED NOT NULL DEFAULT '0',
CHANGE source_file_id source_file_id INT(10) UNSIGNED NOT NULL,
CHANGE flv_file_id flv_file_id INT(10) UNSIGNED NULL DEFAULT NULL,
CHANGE raw_image_1_file_id raw_image_1_file_id INT(10) UNSIGNED NULL DEFAULT NULL,
CHANGE raw_image_2_file_id raw_image_2_file_id INT(10) UNSIGNED NULL DEFAULT NULL,
CHANGE splash_file_id splash_file_id INT(10) UNSIGNED NULL DEFAULT NULL,
CHANGE thumb_file_id thumb_file_id INT(10) UNSIGNED NULL DEFAULT NULL,
CHANGE current_params_id current_params_id INT(10) UNSIGNED NOT NULL DEFAULT '0',
CHANGE dirty_params_id dirty_params_id INT(10) UNSIGNED NOT NULL DEFAULT '0',
CHANGE transcoder_version transcoder_version TINYINT(3) UNSIGNED NOT NULL DEFAULT '0',
CHANGE views views INT(10) UNSIGNED NOT NULL DEFAULT '0',
CHANGE views_completed views_completed INT(10) UNSIGNED NOT NULL DEFAULT '0',
CHANGE downloads downloads INT(10) UNSIGNED NOT NULL DEFAULT '0'
");

_op_video_convert_timestamp_to_int(&$ret, 'op_videos', 'upload_failed');
_op_video_convert_timestamp_to_int(&$ret, 'op_videos', 'uploaded');

$ret[] = update_sql("
ALTER TABLE {op_video_files}
CHANGE filesize filesize BIGINT(20) UNSIGNED NOT NULL DEFAULT '0',
CHANGE keepme keepme TINYINT(1) UNSIGNED NOT NULL DEFAULT '0',
CHANGE dirty dirty TINYINT(1) UNSIGNED NOT NULL DEFAULT '0'
");

_op_video_convert_timestamp_to_int(&$ret, 'op_video_files', 'obtained');
_op_video_convert_timestamp_to_int(&$ret, 'op_video_files', 'deleted');

$ret[] = update_sql("
ALTER TABLE {op_video_params}
CHANGE width width SMALLINT(5) UNSIGNED NOT NULL DEFAULT '0',
CHANGE frame_rate frame_rate TINYINT(3) UNSIGNED NOT NULL DEFAULT '0',
CHANGE key_interval key_interval DECIMAL(3, 1) UNSIGNED NOT NULL DEFAULT '0.0',
CHANGE video_bitrate video_bitrate SMALLINT(5) UNSIGNED NOT NULL DEFAULT '0',
CHANGE audio_bitrate audio_bitrate SMALLINT(5) UNSIGNED NOT NULL DEFAULT '0',
CHANGE keep_source_file keep_source_file TINYINT(1) UNSIGNED NOT NULL DEFAULT '0',
ADD max_duration SMALLINT(5) UNSIGNED NOT NULL DEFAULT '0' AFTER audio_bitrate
");

$ret[] = update_sql("
ALTER TABLE {op_video_stats}
CHANGE type type ENUM('view', 'view completed', 'download') NOT NULL
");

_op_video_convert_timestamp_to_int(&$ret, 'op_video_stats', 'timestamp');

break;
}
Sorry to ask but I am not a coder just user.

Thank you up front.

Tansel

Both of you seem to be using the content type op_video, and now, with the version 3 you're lost.
You must create a new content type, lets call it "video", and then, add all the fields you need (one of the fields should be the of the type "op_video", in order to be able to upload a video when creating this kind of node).
This gives us much more control, because it's more like adding an image field. You can even add more than one video to the node (as you can have more than one text field, or integers...)

Uninstall the old version and start again with the 3. I "lost" some videos, but I was just testing so no worries...

I received this error also after installing the 'stable' version. Would be good if a new stable version was released with this problem fixed. Not a good experience for first-time users of this module.

sorry to say but this was a fresh drupal install. I wanted to test the module before implementing it. The only content type I had is the default story and page.

okay - this is fixed in 5.x-2.x-dev . 5.x-2.3 will be released very soon.

If you want to use op_video module, you need to add CCK also. Then, you will be able to create a new content type, and add the op_video field to this one. That's all.

Automatically closed -- issue fixed for two weeks with no activity.