file_check_location and non-existing directories

Relates to: #261392: file_check_location() fails when file does not exist and #184992: file_check_location() doesn't actually do what is described and #48350: upload module puts tmp file but won't move file to final directory location

we ran into this trying to write unit tests for the hook_file patch (#142995: Add hook_file and make files into a 1st class Drupal object).

marked #261392: file_check_location() fails when file does not exist as a duplicate

Here's the test we built for this bug:

  function testFileCheckLocation() {
    $source = 'misc/fake/xyz.txt';
    $directory = 'misc';
    $result = file_check_location($source, $directory);
    $this->assertTrue($result, t("Non-existent file validates when checked for location in directory, but name contains a non-existent subfolder."), 'File');
  }

I'm forking it from #308434: Clean up file.inc ahead of hook_file and add unit tests. so that all the tests committed will pass.

Made a patch for it.
See http://drupal.org/node/339863 also for D5 patch

drewish's test is not included in the patch?

I don't get it. Should it?
Seems to me that Drewish's patch is already commit, and this patch can still be applied to it.

p.brouwers no you need to incorporate the test that i'd posted in #3

ah ok, will incorporate your test and submit a new patch

ok, added your test drewish and corrected the other tests to reflect the change to file_check_location()

which file we must patch in drupal 6.8 and how?

I'm ok with the patch #9, webform module use file_check_location with /webform/ path in his file_download hook but it doesn't create the webform folder in sites/default/files.

So i get many "realpath() open_basedir restriction in effect" warnings.

What's the current status on this subject?

I am not sure if this is the correct place to put this, so forgive me if I am making a mistake. I made a patch for Drupal 6, with a slight modification: On windows systems, running realpath() on non-existent directories can be very slow in some cases. To avoid this, I moved the is_dir() check to before the realpath() call.

Sorry - left out the directory info in the patch header.

Since the file_check_location function is removed from Drupal 7 this bug was not fixed, but it still effects Drupal 6 sites.

Here is a current patch for 6.x drupal core