Closed (fixed)
Project:
Fullname field for CCK
Version:
5.x-1.2
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
14 Dec 2007 at 14:53 UTC
Updated:
28 Dec 2007 at 17:52 UTC
I hope I haven't just misread the manual on this one. What I'm seeing is a misalignment of the 'th' cells with the 'td' cells. I have prefixes and suffixes disabled for the legal name (preferred name completely disabled). When the module writes out the table, it correctly(?) omits the 'th' cells for those fields, but incorrectly(?) includes empty 'td' cells for them. As a result, the headings are not aligned over their respective columns.
Comments
Comment #1
macco commentedI had the same Problem. I overwrote the following theme-function.
Please use my version only as basis for your version.
Regards,
Macco
Comment #2
rconstantine commentedHey folks, I did run into this myself the other day but didn't have time to work out the problem. It looks like what I need to do is make the lines like this one:
$rows[$delta]['suffix'] = '';contingent on the existence of the same field in the preferred name and visa versa. The rest of the changes to macco's code are customizations and not the bug fix - for anyone that didn't catch that.BTW, the recommended way to customize theme functions is to put copy them to one of your theme's file and change it there instead of changing the one provided with the module. And as for CSS, the recommended practice for changing, or eliminating CSS is to override it in your theme's style.css file (or other). See the Drupal handbooks on theming for more info.
Anyway, this is the proper fix, sorry it isn't a patch (I don't have time right now):
I tested it by requiring the legal name, setting the preferred name to don't use, then using only the first, middle, and last name of the legal name, and requiring only the first and last name. Pre-changes, it was messed up. Post-changes it was fixed.
Thanks for the issue post. I'll get this out in a new release later today.
Comment #3
(not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.