split Schema API and common DB abstraction
hswong3i - December 20, 2007 - 03:54
| Project: | Drupal |
| Version: | 7.x-dev |
| Component: | database system |
| Category: | task |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | duplicate |
Description
(This is a split and lightweight version of http://drupal.org/node/199217)
Schema API is something database-platform dependent, but not PHP DB driver dependent. On the other hand, it seems to be unnecessary complicated to handle 2 section (@ingroup database and @ingroup schemaapi) within single file.
This patch split Schema API into individual schema.xxx.inc files, for a better upgrade and maintenance handling. Just a cut-and-paste handling.
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| split_schema_api-0.1.patch | 59.45 KB | Ignored | None | None |
#1
Makes a lot of sense. Not yet checked it line by line and/or tested it though.
#2
Can't see this happen now. I provided a common.inc and a menu.inc split and Dries said http://drupal.org/node/191448#comment-631812 that we are not splitting inc files in this release. Might be in the next. So, before you reset as you usually do saying that I can't make such decisions, read Dries' saying on this in the linked comment.
#3
(This is part of my personal research project Siren's issue.)
#4
Since D7 is now open for public development, and this is the common base for most of the other DB API revamp handling, hope it is now the good timing for review this patch.
Patch reroll via latest CVS HEAD (7.x). Only coming with basic cut & paste handling, plus very minor essential change in db_version() of MySQL. I don't give any other syntax change nor clean up within this patch, so it should able to work as a reference point for further more development.
#5
sorry that i merge both splitting of Schema API and common abstraction within this patch. BTW, they are still simple cut & paste handling ;-)
----------------------------------------
What do you hope from my personal blog??
#6
I set this issue as duplicated with http://drupal.org/node/199217