Advertisement Drupal 6 Development

redndahead - December 21, 2007 - 22:46
Project:Advertisement
Version:6.x-1.x-dev
Component:ad module
Category:feature request
Priority:normal
Assigned:Unassigned
Status:duplicate
Description

I was wondering if there has been any start to porting this to drupal 6. I have begun the process with the coder module and I am about half way done. Is anybody else also working on it?

#1

Jeremy@kerneltr... - December 22, 2007 - 00:45

Porting to Drupal 6 is very low on my priority list at the moment, as I'm running Drupal 5 on my own websites. I certainly appreciate an effort to port the module, but it's unlikely I'll be maintaining the 6.x branch until I actually have a need myself. Development will continue in the 5.x branch for the foreseeable future.

#2

kpaul - February 15, 2008 - 07:58

Bumping this to the top with the release of Drupal 6 to see if there's any update or anyone else willing to port to D6. Thanks.

#3

fusions - February 17, 2008 - 15:50

Also hoping someone is going to port this.

#4

demoniac - February 19, 2008 - 15:42

I just ran across this for a new Drupal 6 site I am setting up, never having used Drupal 5 or this plugin, I really hope it does get ported to 6 as it looks to do exactly what I need (a nice easy way to show ads in specific blocks).

#5

johanneshahn - February 20, 2008 - 19:43

what is the best way to start porting ad to d6?
i would help

greetz johannes

#6

fm - February 21, 2008 - 03:20

subscribed.

#7

redndahead - February 21, 2008 - 05:23

Use the coder module. It has excellent tools to help you work through the module to make the changes for D6. The issue isn't so much porting to D6 it is getting commitment from the developers or someone else to maintain that port. Not that they're against it it's just that commitment is necessary or you end up with a release that is behind and end up porting again. I started a port, but have stopped as I felt it was better for my needs to create a new module. The port I started is now a few releases behind so it might be better to start from the beginning again. I think someone with a minimal amount of coding experience could finish recoding the coder module suggestions in 4-5 hours time.

red

#8

Jeremy@kerneltr... - February 21, 2008 - 12:40

I am trying to allocate time in March to maintain a Drupal 6 port of the module. If someone has careful per-module patches already started, please attach them.

#9

johanneshahn - March 6, 2008 - 07:11

okay,
i installed the coder modul and already tortoise cvs.
but where to start now.

think the best way is
to port the core and the install/update scripts first
to get a installed ad6 version. then i can fix the error reports of some submodules.
it does not make sense to me to fix all error reports first and hoping it works, without
testing my changes under real conditions.

#10

johanneshahn - March 10, 2008 - 10:47

closed

#11

johanneshahn - March 9, 2008 - 20:02

patch for ad.modul

menu hook function must be convert again by admin.

AttachmentSize
ad.module.patch118.81 KB

#12

coltrane - March 25, 2008 - 17:27

johanneshahn, the patch fails to apply for nearly all hunks. It looks like there have been some commits on the DRUPAL-5 branch but was your patch against ad-5.x-1.x-dev?

#13

johanneshahn - April 7, 2008 - 08:30
Version:5.x-1.x-dev» 5.x-1.4

no this patch was against 5.x-1.4-1 Official releases!

#14

Jeremy@kerneltr... - April 13, 2008 - 03:42

Obviously I didn't find time in March, and I can already see there's no time in April. Perhaps May, perhaps not.

#15

Jeremy@kerneltr... - April 16, 2008 - 00:19

BTW: The site where I'm using the Ad module is also dependent on the Views module and the E-Commerce module. Until they are ported to Drupal 6, it's unlikely that i'll be porting the ad module.

#16

encho - April 17, 2008 - 18:42

Subscribing

#17

wayland76 - April 30, 2008 - 10:40
Title:Drupal 6 Development» Advertisement Drupal 6 Development
Version:5.x-1.4» 5.x-1.x-dev

Johannes -- we should be branching from the dev version, shouldn't we?

#18

wayland76 - April 30, 2008 - 11:14

Btw, I'm in the same situation as some of the others; setting up a new site on Drupal 6.

Views 2 for Drupal 6 seems to be out, but E-Commerce doesn't appear to have been even started.

#19

Jeremy@kerneltr... - May 7, 2008 - 02:34

My dependence is CCK, not Views, sorry I got that wrong above. In any case, I'm very likely to drop my dependence on e-commerce within the next few weeks, at which point I'll revisit the possibility of migrating to Drupal 6 in June.

#20

barinder - May 12, 2008 - 06:48

Hello friends,
I had applied above patch for ad.module and also migrated ad.install , ad.info ,ad_image.install , ad_image.info ,ad_image.install , ad_image.module , ad_report.info , ad_report.module.
I am facing few problems while creating and applying ads to a specific group the ads shown in all groups block
and functionality of the saving groups information is also missing
can somebody has solution to my problem
I had attched the whole ad module in this comment

thanks

AttachmentSize
ad.tar_.gz131.58 KB

#21

wayland76 - May 12, 2008 - 07:09

Barinder; can you tell us what version you started with? Also, patches are more useful than tgzs :).

#22

n33x - May 12, 2008 - 21:37

subscribed.

I am going to blow away the V6 and revert to 5 for this. Might sound crazy but I need to get these sites done. and theis awesome module is exactly what i need. I am losing time howver ... would have been nice to have this module for v6.2. But drupal has saved me so much time already ... and since I have not been able to contribute 'yet' I can only thank those that are helping out.

#23

barinder - May 14, 2008 - 11:40

hello wayland76

I had attached the patch's for different files which I had ported to D6 and for ad.module file I applied patch given above
but still things are not working properly for me.
this patches are against 5.x-1.4-1 releases!

BarinderSingh
MCA Trainee
Gloscon Solutions Inc.
www.gloscon.com

AttachmentSize
ad_report.module.patch8.42 KB
ad_report.info_.patch517 bytes
ad_image.module.patch7.58 KB
ad_image.install.patch5.08 KB
ad_image.info_.patch590 bytes
ad.install.patch14.4 KB
ad.info_.patch485 bytes

#24

wayland76 - May 26, 2008 - 05:12
Status:active» patch (code needs review)

I'm marking this "Code needs review" because of the patch provided by johanneshahn in comment #11. Barinder is obviously having trouble with it.

@Jeremy: A question -- what version do you want patches against? HEAD?

@johanneshahn: Is this patch solely for the Drupal-5 to Drupal-6 port, or does it have lots of additional stuff in it that's specific to your site?

Thanks all,

#25

webchick - May 28, 2008 - 07:00

...

#26

rinvelt - May 30, 2008 - 13:23

subscribing

#27

Jeremy@kerneltr... - May 30, 2008 - 14:48

@Jeremy: A question -- what version do you want patches against? HEAD?

This patches need to be against the latest 5.x-1.x-dev tree to be useful for porting efforts. Thanks.

#28

nbz - June 1, 2008 - 18:33
Status:patch (code needs review)» patch (code needs work)

I had a look and most of that patch in comment 11 seems to mostly be things already fixed in (what is now) ad 1.5, but for me it does not apply to the 1.4 release.

Is there a way to get a diff from that patch and HEAD to see what really is different?

#29

jorisx - June 7, 2008 - 20:11

Great module! I'm using it on several 5 installs and I'm now bussy converting some site's to drupal 6.

Did anyone test the patches of #23 to 1.4 or 1.5 ?
With which version is that patch now working ? :-)

I would like to test this module on a drupal 6 site if available :-)

#30

nbz - June 7, 2008 - 21:08

The patches would not apply for me (against 1.4). Looking at the code, it seems they reimplement quite a bit of what is now in 1.5 (but not all).

Best option seems to be to start a new patch.

#31

papasj - June 9, 2008 - 17:17

subscribing

#32

jorisx - June 12, 2008 - 12:20

Hi Barinder,
I this patch still working against ad.module ad 5.x-1.4 or ad 5.x-1.4-1 to port it to 6.0 ?
http://drupal.org/files/issues/ad.tar_.gz

(would like to know because i don't really know how to set up a new patch..)

#33

moshe weitzman - June 17, 2008 - 19:38

subscribe

#34

nbz - June 18, 2008 - 00:03

I have just run the ad module through coder and schema modules to get an initial patch. Not much tested, but it should be a start.

Not working:

1. atleast one of the menu items.
2. around line 1559 (after applying the patch), I have commented out a couple of lines.

Working: no idea.

I have not tested it much more than installing the module, clicking create content > advertisement.. I expect there to be loads more to do, but now most of the tedious stuff should be done.

PS this patch is against the dev version from 13 June.

AttachmentSize
ad.d6.patch54.67 KB

#35

brianestadt - June 27, 2008 - 15:21

subscribe ...

And wondering about the likelihood that a 6.x version will be available for the start of August. I'm starting a new site with an expected Aug. 1 launch date, and I'm wondering if I should go with D6x (preferred) or D5x (not so preferred). Given that this module will be essential to the site, it's availability status will make that decision for me.

Apologies if this comes across as a nag. I wholeheartedly appreciate the work of this module's original designer and those working on the update.

#36

Jeremy@kerneltr... - June 27, 2008 - 15:34

The recent decision to postpone the release of Drupal 7 has made me much more interested in working to port my modules to Drupal 6, now knowing that it's going to be around for a while. By August? Perhaps. Hopefully. But perhaps not. Sorry, there's no way I can give you a definite answer.

I plan one more major release for the 5.x branch which will include numerous contributed features currently in the issue queue, geotargeting, and some features I've added in my devel sandbox for Ad Bard. I will then be focused on upgrading Ad Bard to this version of the code. Once that is complete, then I plan to port this module to 6.x. How quickly all of this happens is impossible to say, too many variables.

#37

moshe weitzman - June 27, 2008 - 20:48

I'd like to see D6 too. But in the meanwhile, it is perfectly possible and reasonable to run 2 drupal installs. your first is your main site which is on d6 and the second is ad.module only which runs d5. then copy your ad html to your D6 templates as desired. this ad html export is a built in feature of ad.module

#38

duellj - July 3, 2008 - 04:16

subscribing.

#39

MedicSean37 - July 3, 2008 - 19:42

Now that views2 and cck for drupal 6 is out, i've got to have only two more "most have" modules with a 6.x support for me to make the switch. Panels, and the Ad module. I'm hoping that the ad module will support drupal 6 soon.

#40

mark_story - July 10, 2008 - 16:52

I've been working on upgrading this module for the last day or so. I'm not totally familiar with drupal 6 yet, however the base ad, image ad and reporting seem to work so far.

There were problems with the previous patches posted here in that the schemas were entirely wrong. There were small int fields for datestamps which created far reaching problems. If this was a module generated schema then someone should really look into fixing that module as trying to use small int fields for datestamps does not work at all.

I won't be able to port all of the sub modules as I don't have the time, nor the requirements to port them. However, once I get the three modules I'm using done I'll post patch(es).

#41

nikemen - July 13, 2008 - 02:17

subscribed

#42

domesticat - July 15, 2008 - 15:42

Subscribing.

#43

Miraploy - July 19, 2008 - 20:37

subscribed

#44

sportman1280 - July 23, 2008 - 15:06

Please keep this going... i really wanna use this module!

#45

pablillo - July 24, 2008 - 22:32

I´m needing this module too. I´ve tried the rotor banner module but it doesn´t have all the functionality i´m looking for working with ads, in contrast of the ad module.
I dont know yet how to contribute with the modules and also i dont have much time to learn it now, so i depend entirely on the actual contributors of this module (are there anyone seriously porting it to d6?). Can anyone give an aproximate date for this to be acomplished??
I´m not criticising, for the contrary, i would like to thank you all for the great cms that you are making!
Thanks

Pablillo

#46

erniem - July 25, 2008 - 16:07

subscribing. and i second all of the requests for a D6 version above. great module--thank you!

#47

Garrett Albright - July 29, 2008 - 17:56

Here is an INCOMPLETE patch against the 1.5 release. ad.install, ad.info and the rather hairy hook_menu() of ad.module are probably complete, as well as other various hooks and functions in ad.module, but it's nowhere near complete as a whole. I started working on this, but saw how slowly I was progressing and gave up… but perhaps this can serve as a starting point for someone with more time to spend on this… in my case, it would be less work for me to just restart our project from D5 (ugh) than continue trying to port this!

What we'll probably end up doing is running a separate D5 installation to serve ads, as moshe suggested above. Hopefully the client will find that acceptable.

AttachmentSize
ad-d6-so-far.patch49.58 KB

#48

Electronick - August 6, 2008 - 12:26

subscribing...

#49

duntuk - August 8, 2008 - 19:57

subscribe

#50

arleym - August 9, 2008 - 02:41

subscribed

#51

Jeremy@kerneltr... - August 11, 2008 - 21:30
Status:patch (code needs work)» duplicate

With the 5.x release of Drupal 1.6, I'm now ready to focus on porting the ad module to Drupal 6. I have created a 6.x-1.x development branch, and used deadwood to start the porting process. I've created a separate issue for each module that needs to be ported, allowing us to better track the process.

I welcome patches against the existing 6.x-1.x-dev branch to help with the porting effort, but please do so in the appropriate issue.

#52

katetwiss - August 21, 2008 - 00:55

would like to subscribe...

#53

cwdrup - September 11, 2008 - 20:06
Version:5.x-1.x-dev» 6.x-1.x-dev
Component:installation» ad module

subscribed.

 
 

Drupal is a registered trademark of Dries Buytaert.