Remove node references when the referenced node is deleted

Here's one for my needs.

/**
 * Ensure that pointers are not left dangling when a nodereference target is
 * deleted.
 * Going straight at the Database because I can't see any API for this type of
 * housekeeping.
 */
function nodereference_nodeapi(&$node, $op, $teaser, $page) {
  switch ($op) {
    case 'delete' :
      $nodereferences = db_query("SELECT field_name FROM {node_field} WHERE type='nodereference'; ");
      // Find all possible nodereference types, and wipe all uses that mention this node
      foreach (db_fetch_object($nodereferences) as $nodereference ) {
        db_query('DELETE FROM content_%s WHERE %s_nid = %d', $nodereference->field_name, $nodereference->field_name, $node->nid);
      }
  }
}

This still seems to be an issue in the latest (5) checkout today.

In the patch here I also added a thing to stop dead links show up when editing the original pointer. In theory you won't need both these fixes at the same time ... but choose which repair-job approach you prefer.

I did attach the patch, really!

i resouled the problem by this code in content.module from line 446 to 510

    case 'update':
      if ($field['multiple']) {
        // Delete and insert, rather than update, in case a field was added.
	db_query('DELETE FROM {'. $db_info['table'] .'} WHERE nid = %d',$node->nid); // line 449
        db_query('DELETE FROM {'. $db_info['table'] .'} WHERE vid = %d', $node->vid);
      }

      foreach ($node_field as $delta => $item) {
        $data = array();
        $column_names = array();
        $column_placeholders = array();
        $column_assignments = array();
        foreach ($db_info['columns'] as $column => $attributes) {
          $column_names[] = $attributes['column'];
          if ($item[$column] == '' && !$attributes['not null'] && !$field['required']) {
            $column_placeholders[] = '%s';
            $column_assignments[] = $attributes['column'] .' = %s';
            $item[$column] = 'NULL';
          }
          else {
            switch ($attributes['type']) {
            case 'int':
            case 'mediumint':
            case 'tinyint':
            case 'bigint':
              $column_placeholders[] = '%d';
              $column_assignments[] = $attributes['column'] .' = %d';
              break;
            case 'float':
              $column_placeholders[] = '%f';
              $column_assignments[] = $attributes['column'] .' = %f';
              break;
            default:
              $column_placeholders[] = "'%s'";
              $column_assignments[] = $attributes['column'] ." = '%s'";
            }
          }
          $data[] = $item[$column];
        }
        $data[] = $node->vid;
        $data[] = $node->nid;
        if ($field['multiple']) {
          $data[] = $delta;
        }

        if ($field['multiple']) {
              db_query('INSERT INTO {'. $db_info['table'] .'} ('. implode(', ', $column_names) .', vid, nid, delta) VALUES ('. implode(', ', $column_placeholders) .', %d, %d, %d)', $data);

        }
        else {
          if (db_result(db_query('SELECT COUNT(*) FROM {'. $db_info['table'] .'} WHERE vid = %d AND nid = %d', $node->vid, $node->nid))) {
            db_query('UPDATE {'. $db_info['table'] .'} SET '. implode(', ', $column_assignments) .' WHERE vid = %d AND nid = %d', $data);

          }
          else {
             //delete the old data 
    	    db_query('DELETE FROM {'. $db_info['table'] .'} WHERE nid = %d',$node->nid); // line 504 
            db_query('INSERT INTO {'. $db_info['table'] .'} ('. implode(', ', $column_names) .', vid, nid) VALUES ('. implode(', ', $column_placeholders) .', %d, %d)', $data);

          }
        }
      }

Did this issue get incorporated into CCK for D5 or D6? I find it to be extremely critical

I need this too for D5. is the code from #3 tested already?

This is the oldest issue I've found on the subject: #83929: referential integrity

I think this is causing major issues on my test server