Allow menu links pointing to dynamic paths

agreed - I recall the intent for D6 was to allow the editing (or addition, I guess) of items in the Navigaiton menu like user/% that always have a valid return from the _to_arg.

Patch partially applied :

--- Successfully Patched ---
modules\aggregator\aggregator.module
modules\contact\contact.module
modules\filter\filter.module
modules\forum\forum.module
modules\node\node.module
modules\taxonomy\taxonomy.module
--- Failed ---
includes\menu.inc (Cannot apply hunk @@ 7 )
modules\menu\menu.admin.inc (Cannot apply hunk @@ 7 )
modules\menu\menu.module (Cannot apply hunk @@ 6 )
modules\user\user.module (Cannot apply hunk @@ 6 )

Would this allow the following scenario?

* Create a taxonomy vocabulary "product"
* Create the terms "cats", "dogs", "elephants" in the "product" taxonomy
* Create a view page named "product/%" that accepts an argument of a term from the "product" taxonomy
* Create a menu item with the link_path "products/cats"

Currently in D6 this is not possible, and is a major limitation to the flexibility of all modules that can create custom pages, e.g. Views, Panels, etc.

Damien

Please please please!

This is one of the questions I see most often on IRC/forums. It would make user profiles more linkable, for example if you're encouraging a user to fill out a certain section of their profile and need to have their UID in the path. Also an issue I see often with Ubercart -- you can't link to user/[uid]/files to send a user directly to their purchased files tab, order history, invoices, etc.

From #drupal:
The thing I don't like about it is that it seems like *every* module that defines a %something arg needs to define a function like aggregator_feed_to_arg(). and if one of them doesn't, then the behaviour people get is inconsistent.

The only difference between menu_to_arg and node_to_arg is how you're doing menu_get_object and what $arg is returned. That seems like a lot of copy/pasting for module developers for two lines of code. We're also exposing menu system internals like $map and $index.

What if these functions were something like:

function node_to_arg($node) {
  if ($node) {
    return $node->nid;
  }
}

and the menu system handled the background stuff?

I'm unlear from the whether a to_arg function is required or not for each % argument?

Bumping priority. Not being able to link to valid paths is a bug, and it's causing complaints at #308263: Allow privileged users to bypass the validation of menu items (which I downgraded).

will this work in D6?

Tabs as menu links would make things like og_panels a lot easier, and means you could do things like add a views argument as a tab.

subscribe

Let's see if this one still applies.

Re-rolled against latest HEAD.

This indeed qualifies as critical bug. Tagging to get into my list of issues to push.

This one will pass.

The concept needs work though.

.

Subscribe

Subscribe, patch outdated

This could easily solved with #320331: Turn custom_url_rewrite_inbound and custom_url_rewrite_outbound into hooks

subscribe

@andypost: those issues are pretty much unrelated.

bump - this should still be a critical fix for D7

subscribing...

#9: dynamic_menu_links.patch queued for re-testing.

Related contrib module: http://drupal.org/project/menu_token

Related #144538: User logout is vulnerable to CSRF

Refactoring of menu in #1463656: Add a Drupal kernel; leverage HttpFoundation and HttpKernel will make this obsolete

So is this issue now obsolete?

This deals with paths, which do not exist in D8 anymore => Back to 7.x