1- an easy fix: missing t('') in the breadcrumb. See patch.
2- still with the breadcrumbs, I have not seen where the string "projects" is set. I don't seem to be able to translate that part of the breadcrumbs.
3- I am not sure whether this should be a potx issue or a project_issue issue: when generating the .pot file for project_issue using the php potx-cli, I had the following error:
[augustin@203 project_issue-5]$ php potx-cli.php
Processing comment.inc...
Processing issue.inc...
Invalid marker content in issue.inc:1600
* t($node->category)
Processing mail.inc...
Processing project_issue.module...
Processing project_issue.install...
Invalid marker content in project_issue.install:748
* t("This and all subsequent updates of Project issue were safely aborted. Correct the problems listed above, then <a href=\"".base_path()."update.php?op=selection\">re-run update.php</a>, click 'Select versions', select update %update for project_issue, and click 'Update'.",array('%update'=>$current_update))
Processing project_issue.info...
Processing generate/project_issue_generate.inc...
Processing generate/project_issue_generate.module...
Processing generate/project_issue_generate.info...
Done.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | missing-t-project-issue2.patch | 1.42 KB | beginner |
| missing-t-project-issue.patch | 836 bytes | beginner |
Comments
Comment #1
beginner commented3 more t('').
Comment #2
hunmonk commentedapplied patch in comment #1 to 5.x-2.x, 5.x-1.x, and 4.7.x-2.x
re: #2 -- what does the breadcrumb look like that you're trying to translate. i can't tell which one to look for with your description.
please open another issue for problem #3
Comment #3
dwwEek. The patch from #1 is wrong, where you added t() around the issue priority values. We use those in menu paths and such, where you can't just translate them without introducing all kinds of weird errors. I *know* I wrote all of this up somewhere, but I can't find it right now. :( Anyway, we should back-out that part of the change, and either find the other issue or open a new one about what it'd take to be able to safely translate the priorities.
Problem 3 is definitely stuff wrong in project_issue, not potx. You can't put dynamic stuff inside t().
Comment #4
beginner commentedI thought point 1 and 2 would be trivial, that's why I lumped all 3 together.
Since it is not, I opened a separate issue for point 3:
http://drupal.org/node/206210
1- missing t(): do you mean there is no way to translate 'critical', 'normal' and 'minor'?
2- at node/43, when viewing an issue, the breadcrumbs look like this:
Accueil › Projects › Le site Ouvaton AL/PT › Problèmeswhich is the translation ofHome › Projects › My site name › Issues."Projects" is not translated and leads to
/projectwhich seems to correspond to "Download" on this site...... Oh! Ok, I found it. It is a menu item. I can translate it there. The menu item was disactivated on my site, though. Is it still supposed to appear in the breadcrumbs?
Comment #5
hunmonk commentedwell, gosh -- it would have been nice to have a code comment there to that effect in the first place ;)
rolled back the relevant stuff on all branches, and added an appropriate code comment so this doesn't happen again...
Comment #6
beginner commentedcross posted.
Comment #7
beginner commentedThanks for fixing the other stuff.
Can we know why we can't translate the priority settings, and what it would take to be able to do so?
Comment #8
dwwUpon closer inspection, I'm being dumb. ;)
http://drupal.org/cvs?commit=94420
Fixed in all branches.
Sorry everyone.
Comment #9
beginner commentedThank you :)
Comment #10
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.