The digest field in subscriptions_user is set to "-1" in mysql 5 with d5. I'm guessing this is to disable the digest mode and it hasn't been fully implemented yet. However, it's still used when cron hooks is run.

Once the patches from here and here are applied, the attached patch should fix the problem.

CommentFileSizeAuthor
subscriptions_digest_disable.patch701 bytestro-1

Comments

salvis’s picture

Status: Needs review » Reviewed & tested by the community

Oops, thanks!

-1 is supposed to mean "use the site default", but nothing is implemented yet, and your patch is a good fix for now.

BTW, we're trying to keep from ripping through beta releases too quickly, that's why we have some uncommitted issues in the queue -- they'll all be in BETA8 of course.

gustav’s picture

Just saw your comment about uncommitted issues here after posting a question about this in another issue with an uncommitted fix. Committing code fixes to CVS is completely unrelated to making beta releases. There is no reason to wait with commits until you are ready to make another release. It would be very convenient for those of us who use CVS if bug fixes were committed to the 5--2 branch as soon as they are available. Many thanks!

salvis’s picture

Ok, committed to cvs, will mark it fixed when BETA8 is out.

Between chx and me we work with svn, which is much better than cvs, and he typically commits one big merged patch including all pending patches before creating a new beta release, but I can commit pending bug fixes if that helps you, at least when they're small and likely to merge cleanly.

gustav’s picture

Ah, thanks for the explanation. We also work with svn. Our subversion repository also contains the CVS folders, so that it is very easy for us to merge our changes with those in the CVS repository and to commit our changes back to CVS. We just have to remember to commit the changed CVS folders to our svn repository each time we make a CVS commit. I assume you have a similarly convenient method. In any case: many thanks for the commit.

salvis’s picture

That's an interesting idea! Can you hide the .svn folders from CVS?

I'm using Eclipse for development and CVS, and that imposes a number of additional restrictions. I like having the core files of my development site under (cvs) version control, but that means that I can't have the contained contrib modules under a different cvs project at the same time. svn comes in handy, because it's orthogonal to cvs (not through Eclipse though, but with TortoiseSVN). This means I have to separately apply the patches to the cvs contrib project and commit, but if I already have the patch, then it's only a small additional step.

gustav’s picture

That's an interesting idea! Can you hide the .svn folders from CVS?

I use TortoiseCVS and TortoiseSVN. My development sandbox has both the CVS and the .svn folders. The .svn folders are hidden from TortoiseCVS. The CVS folders are visible to TortoiseSVN, which is as I want it because those should be committed to the subversion repository.

salvis’s picture

Ah, I was wondering whether the two tortoises would get along with each other. I'll definitely keep this in mind. For now, the cvs integration in Eclipse works pretty well for me, since I use Eclipse as IDE.

salvis’s picture

Version: 5.x-2.0-beta7 » 5.x-2.0-beta8
Status: Reviewed & tested by the community » Fixed
salvis’s picture

Version: 5.x-2.0-beta9 » 5.x-2.0-beta8

@delius: If you use the two tortoises on the same directory tree, how can you keep them from fighting about which icons to display? Set Status Cache to None on one of them? Does that work?

gustav’s picture

Version: 5.x-2.0-beta8 » 5.x-2.0-beta9

@salvis: Good question. I have not worried about that. Hence I don't know how they fight that out. I don't rely on the icons very much. If you need that information you can enable the SVN status and CVS status fields in the file explorer (by right-clicking on the header bar in the Details view).

By the way: I am impressed by the new beta 9! Many thanks for all that work!

Anonymous’s picture

Version: 5.x-2.0-beta8 » 5.x-2.0-beta9
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.