Project page

Content Nodes

Git

git clone --branch 7.x-1.x http://git.drupal.org/sandbox/Peter/2075777.git

Module Content Nodes

This module append nodes as "content" to a node. This module use entityreference to safe the relations. The motivation was to find a solution the use of different content elements simular to the typo3 content elements.

I tried different modules like Panels, or combination of views, but in my opinion there was no method to add new content elements easily.

This module does use not more than the entityreference module, but as an editor you will get a better user experience, at least I think so.

Content Nodes offers

- add new nodes as entity reference directly to a node
- add different content node fields to node types
- show assigned nodes in an extra table view for reorder

Requirements

Entity reference

Recommed modules

Simular modules

Comments

PA robot’s picture

PA robot commented
Status: Needs review » Needs work

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxPeter2075777git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

peterla’s picture

peterla commented
Status: Needs work » Needs review

Sorry, my coder module was not configured correctly. Now coder and pareview reports no errors more.

tibezh’s picture

tibezh commented
Status: Needs review » Needs work

Hi peterla, great work!
But I have found next notices.

  1. content_nodes.module file (function content_nodes_node_list_form_submit) - if php 5.3 is required for your module, than write this in info file. (manual)
  2. content_nodes.module file (line 262) - need use field_language function, because now I see problem with multilangauge sites.
  3. content_nodes.admin.inc file (function content_nodes_settings_form) - please, use l() function for build table rows.



Recommends:

  1. Please, define "admin/config/content_nodes" config page in the .info file of module.
  2. content_nodes.module file (function content_nodes_node_list) - contains drupal_set_title, instead of this use 'title callback' and 'title arguments' (hook_menu)

Kind regards

peterla’s picture

peterla commented
Status: Needs work » Needs review

Hi tibezh,

thank you for review. Your issues are fixed with the last commit, except the last one. To this I can't agree with you. I don't need title callback for changing the tab title, I like to change the page title. The core module node.module uses the same option, see node/%node/edit implementation, so I thought, that is the right way. Can you give me an example, how to set the page title in a better way?

Best wishes, Peter

gaurav.pahuja’s picture

gaurav.pahuja commented
Status: Needs review » Needs work

Issues

  1. Why are we not creating fields that starts from 'field_'?
  3. info file has location of test file but none exists inside repository
peterla’s picture

peterla commented
Status: Needs work » Needs review

Hi Gaurav,

the info file is updated, thank you for the hint.

The fields are prefixed with "content_nodes_", because I don't want any mismatches between fields that are created by this module and the fields, that are created by user. The content nodes fields are identified by prefix, see function _content_nodes_find_fields() in content_nodes.module line 615. I think it is better, than a named merge of the user created fields. Maybe in a later version I can easier delete this fields by an uninstall/cleanup method, if necessary.

Best wishes, Peter

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Reviewed & tested by the community

I test it and no report any errors, work fine.
Its a fantastic module and usable!

Well done.

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
Status: Reviewed & tested by the community » Fixed

Looks good to me as well, nice work!

Thanks for your contribution, peterla!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.

----
Top Shelf Modules - Crafted, Curated, Contributed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

(not verified) commented
Issue summary: View changes

Update git path only