for me this is a bug (already submited in the bug section) however I will be happy to know a workaround otherwise I can't use this module for a french site which is a shame only for a keyword that can't be translated

CommentFileSizeAuthor
#1 forward_pot.txt11.9 KBEncarte

Comments

Encarte’s picture

Assigned: Unassigned » Encarte
Status: Active » Fixed
StatusFileSize
new11.9 KB

Updating the translation files seems to be the only way to fix this issue. Some steps are required to do that:

  1. Download the .pot file attached to this issue (the .pot file in the module /po subdirectorie is out of date). After downloading the attachment, you have to change its extension from forward_pot.txt to forward.pot (I attached it like a .txt because I don't seem to have permissions to attach a .pot file);
  2. Go to the /po subfolder of the Forward module;
  3. Open the .po file for your language (e. g. fr.po for french language) with a .po file editor like Poedit or some other. If there is still no .po file for your language, you will have to create one (see the next step);
  4. Update or create the .po file for your language from the .pot file previously downloaded («updating/creating from» is an option available in Poedit and other .po files editors);
  5. Create a translation for «Email this page» in the .po file (translating/updating all the strings in the .po file would be best);
  6. Import you new .po file from the location module (/admin/settings/locale) at your site;
  7. Post the new po. file in Forward issues (or in CVS if you have the permissions) so that it will be committed to new module releases.

Since I'm a complete PHP ignorant I don't know if this is the easiest solution, but it worked for me.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

Ehud’s picture

Status: Closed (fixed) » Active

I tried this solution and it didn't work for me.
But when i translate only the 'Email this' phrase, it works. I omit the !type from the translation.

seanr’s picture

Not sure how else that would work (since email this and page are being intercepted as separate strings), but there might be a documentation need for that somewhere. I'll look into it.

pmichelazzo’s picture

I think that this is an error on the module code.

I change the line 639 from
'title' => t('email this !type', array('!type' => $forward_link_type)),
to
'title' => t('email this page'),
and now it's working.

mjourney2’s picture

Version: 5.x-1.12 » 6.x-1.x-dev

Having the same problem in 6.x

The text that appears at the top of the node updates to the translated text, but the text after the teaser always stays as "Email this page". Translations and string overrides didn't do the trick.

What am I missing?

Thank you

seanr’s picture

Status: Active » Closed (won't fix)

Did you try translating "Email this" and "page" separately? That's the only way to make that work and have the node type names still be able to be used there.

zilverdistel’s picture

Category: support » bug
Status: Closed (won't fix) » Active

Having the same issue with 'Forward this'. Searching through the translations (admin/build/translate/search), I'm not getting any results ...

anieves’s picture

Issue tags: +missing t function traslatable string

The problem was here (or maybe one more 'no translatable string')


function forward_menu() {
  $items = array();
  $items['epostcard'] = array(
    'title'            => variable_get('forward_epostcard_title', 'Send an e-Postcard'), // Missing t()
    'page callback'    => 'drupal_get_form',
    'page arguments'   => array('forward_form', 'epostcard'),
    'access arguments' => array('access epostcard'),
    'type'             => MENU_NORMAL_ITEM
  );
  $items['admin/reports/forward'] = array(
    'description'      => 'Track forwarded posts', // Missing t()
    'title'            => 'Forward tracking', // Missing t()
    'page callback'    => 'forward_tracking',
    'access arguments' => array('administer forward'),
  );
  $items['admin/settings/forward'] = array(
    'description'      => t('Configure settings for forward module.'), // Okay! Great!
    'title'            => 'Forward', // Missing t()
    'page callback'    => 'drupal_get_form',
    'page arguments'   => array('forward_admin_settings'),
    'access arguments' => array('administer forward'),
    'type'             => MENU_NORMAL_ITEM
  );
  $items['forward/emailref'] = array(
    'title'            => 'Track email clickthrus', // Missing t()
    'page callback'    => 'forward_tracker',
    'access arguments' => array('access content'),
    'type'             => MENU_CALLBACK
  );
  $items['forward'] = array(
    'title'            => variable_get('forward_email_title', 'Forward this page'), // Missing t()
    'page callback'    => 'forward_page',
    'access arguments' => array('access forward'),
    'type'             => MENU_CALLBACK
  );
  return $items;
}

miaoulafrite’s picture

actually adding a t() there does not change anything

there is at line 491 a drupal_set_title without a t()
the line should be:

<?php     drupal_set_title(check_plain(t(variable_get('forward_page_title', 'Forward this page')))); ?>

please review it and commit it to the next release thanks

anieves’s picture

Status: Active » Reviewed & tested by the community

Yes, this fix the original problem, the title when you send a page to friend can be translatable now.

Thanks.

john.oltman’s picture

Status: Reviewed & tested by the community » Closed (duplicate)

Duplicate of other issues and resolved by this commit:

http://drupalcode.org/project/forward.git/commit/7bb0236