Closed (duplicate)
Project:
Simplenews
Version:
7.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
9 Jan 2008 at 15:11 UTC
Updated:
2 Dec 2011 at 10:56 UTC
Jump to comment: Most recent file
Comments
Comment #1
sutharsan commentedbenjamin, it sounds very interesting. Simplenews 6 may benifit from this effort, actions integration is in my roadmap, UI improvements are always welcome and different e-mail address for users is an interesting new persprective. For Simplenews 5 this surely needs to be a module, for 6 we can discuss.
Comment #2
ugesh541 commentedHi,
How to create a signup block for selecting multiple newsletter in drupal 5.x
Please help me
Comment #3
sutharsan commented@forums4poc, it is not good practice to use an issue for a related question. Please create a new issue for your support request.
Comment #4
zoo33 commentedHi. First of all, my apologies to Benjamin for hijacking his issue.
I needed a subscription block like this too, and since it's been a couple of months since Benjamin's post I thought I'd take the matter in my own hands and write a small module which simply loads the form that Simplenews already provides at
newsletter/subscriptionsand sticks it in a block.The module is called simplenews_multisignup and is checked into CVS. Before I publish it, I just want to check with Sutharsan if it would be better to turn this into a patch for Simplenews. Also if Benjamin has done some work in addition to what I did, then maybe we should try to merge our efforts?
Comment #5
sutharsan commentedI propose to make a patch for simplenews 6.x-dev for this. I have the plan to make a simplenews sub-module with several extra subscription functions. This will also include the current Simplenews on Register features.
Comment #6
zoo33 commentedOK, so maybe I should still publish it for the 5.x branch then. Guess you're adding functionality only to 6.x by now?
Comment #7
sutharsan commentedIndeed. I have no plans to extent Simplenews 5.x with new functionality.
Comment #8
zoo33 commentedOK, so here's a patch against 6.x. This is basically what I did in the module I was talking about. Not sure if everything is implemented the best way possible, but it works and it's a start. (In particluar, take a look att template_preprocess_simplenews_block_all() where I had to include an inc file manually.)
Comment #9
sutharsan commentedThanks for the patch. It is usefull as a start. However I would use an alphanumeric delta (e.g. 'all-newsletters') instead of '0'. You could move the preprocess function to the simplenews.subscriptions.inc. This would get rid of the include_once(). And last (but not least) please observe the indentations where you have added curly brackets.
Comment #10
zoo33 commentedThat's excellent input!
I forgot to mention that I used the -b option (i think it is) to ignore whitespace, so that the patch would be easier to read. I'm including two versions of this new patch, one with whitespace changes and one without. (I actually found a whitespace error in the current
hook_block($op = 'view').)I followed your suggestion for the include file (should have been obvious to me). Also simplified and cleaned up a few things.
Comment #11
pebosi commentedCould you update your patch to the latest dev Version?
regards
Comment #12
zoo33 commentedHere is an updated patch.
Comment #13
dschneider commentedI'd love to see that in the module. What's blocking that issue? May I be of any help?
Comment #14
zoo33 commentedThe patch may need to be rerolled against the current version in CVS by now. Other than that, positive reviews and tests always help.
Comment #15
yngens commentedsubscribe
Comment #16
zonny commentedI need some help, please.
I have all 4 patch file in folder (modul) "simplenews_multisignup" stored and updated. I get the following error message:
>patch -p0 < simplenews_all_subscriptions_block.patch
patching file simplesnews_/simplenews_all_subscriptions_block.patch
Assertion failed: hunk, file ../patch-2.5.9-src/patch.c, line 354
This applicaton has requested the Runtime to terminate it in an unusual way. Please contact the application's support team for more information.
Comment #17
zoo33 commentedThe patch probably needs to be updated because of other changes that have been made to the module since it was created.
Comment #18
cesareaugusto commentedWhat about the status of this multiple newsletter signup block? How could I get it work on my website? I read this featur shall be implemented into the main 6.x version module. I installed it but I cannot find any feature of this kind. I'm a newbie into Drupal :) Can anyone help me? Thanks! :D
Comment #19
tgeller commentedsubscribe.
Comment #20
crizPatch from #12 rerolled against the current version in CVS. Works for me.
Comment #21
crizComment #22
mnp commentedsubscribe
Comment #23
seren10pity commentedHi, I implemented the patch on the lates dev version of simplenews, but I can't see any new options to combine the subscription blocks into one.
Could it be a versioning problem, or maybe I didn't watched the right place ? What is supposed to change ?
thanks.
Comment #24
ambientdrup commentedThis is actually posted as a module here:
http://drupal.org/project/simplenews_multisignup
This way you don't have to run the patches. The module does it. I just installed the 6.x dev version and it works fine.
Hope that helps.
=backdrifting
Comment #25
matteoraggi commentedOn block and also on newsletter/subscription for me it don'twork, it ask for n email if logghed off, but it don't show the 4 newslettes that I have on my site in drupal 6.14 using last stable version of simplenews.
Comment #26
miro_dietikerI still hope we will be able to bring this functionality into simplenews. it would be much better maintained in case of api changes. Currently if we change things we need to update many external modules and everything is still pretty -dev.
What's exactly the reason not to add it to DRUPAL-6--2 -dev? There's nothing unnatural and it's a great starting point.
Comment #27
sutharsan commentedThis functionality may get into simplenews, but not this patch. It looks way to complex. A simple block is what we are looking for, not with the options the current single newsletter has. This can be build as a separate form and not combine it with existing forms.
Comment #28
millions commentedsubscribe.
Would love this to be built in.
Comment #29
sutharsan commentedmillions, great that you support this. What can you do to make this happen?
Comment #30
millions commentedUnfortunately not much! Just wanted to let Ben know. After posting this I found the multiple signup block which helps though!
Comment #31
sutharsan commentedComment #32
miro_dietikerWe've added a multi subscription block with the
#805114: Cleanup Form creation processes comment #21
Project simplenews_multisignup is obsoleted for this release and future then.
Comment #34
miro_dietikerOK then, this needs port.
Triggered by duplicate
#1165494: Multi signup block
Possibly in relation with #805114: Cleanup Form creation processes
Comment #35
webchickTagging (hope this isn't incorrect).
Comment #36
miro_dietikerComment #37
berdirThis has been closed as a duplicate of #805114: Cleanup Form creation processes before, the code that adds the multi-sign up block is added in the patch there, I'm working on porting that.