Here's a slightly edited version (I'm thinking it's close to ready to go):
Background
The Embedded Media Field (emfield) is a module that adds a CCK field type that allows for easy insertion of media hosted on popular third party sites. Emfield can be extended by adding new provider files (usually called %provider%.inc) to the module's folder. In the past the module has supported embedded video fields (i.e. youtube, revver, blip.tv) and embedded image fields (i.e. flickr, photobucket, etc), but as of Jan 08, 2008, emfield now comes with an Embedded Audio Field (emaudio) module which allows for embedded audio fields.
Task
The initial release of emaudio only supports one audio provider--podomatic.com. The task here is to extend emaudio to support 2-3 new providers, preferably those providers that will be in the most demand. In order to do this the student will have to do the following:
- Research possible third party audio providers for candidates (some possibilities are: facebook, yahoopodcasts, podcast alley, podcast ready, itunes)
- For selected providers the student will need to research whether the provider has an API to interact with their site.
- Using the podomatic.inc provider file as a guide, the student will need to create a provider file for each provider they are adding. Some of the tasks that go into this step include: studying the providers api (if available), studying feeds from the providers (if available), figuring out the RegEx that will be needed for emfield to parse the link that users paste into the field.
- If the site provides an embed code, ensure that users can paste either the url or the embed code.
- Test the file works in at least three browsers and ensure that the code it creates is xhtml compliant.
Primary Contact(s)
- Aaron Winborn (aaron) with help from Alex Urevick Ackelsberg (Alex UA)
| Comment | File | Size | Author |
|---|---|---|---|
| #18 | lastfm.inc_.txt | 7.38 KB | joachim |
| #11 | newproviders.patch | 12.53 KB | Mgccl |
| #7 | newprovider.patch | 12.19 KB | Mgccl |
| #4 | newprovider.zip | 4.52 KB | Mgccl |
Comments
Comment #1
aaron commentedadd odeo and evoca to that list of suggested providers, re http://drupal.org/node/162927
Comment #2
aaron commentedalso, shouldn't this be in the ghop queue?
Comment #3
alex ua commentedIt only stays in the ghop queue until it is approved, after which time it is added to the effected module's queue and tagged with GHOP.
Comment #4
Mgccl commentedI added odeo and podcast alley :)
strange... the patch file only says I added 2 file... but doesn't include those 2 files. so I have to zip it >.<
Comment #5
aclight commentedIt doesn't look like you created your patch correctly. I'm not sure what tool you used, but if you haven't already I'd recommend looking at http://drupal.org/patch/create for more information. There's a section there about how to add new files to a patch. You'll want to use cvs for this. If you're on windows (which I'm guessing you are, due to the windows line endings in the code, which is also a no-no :) ), I'd recommend getting a command line cvs client such as what you can get using cygwin or cvsnt.
There are some coding style issues throughout, including:
1.) Windows line endings.
2.) Tabs instead of 2 spaces in podcasstalley.inc
3.) Comments should be sentences with capitalized first letters and periods.
4.) Instead of "hook emaudio_PROVIDER_thumbnail" in a comment I'd say something like:
"Implementation of hook emaudio_PROVIDER_thumbnail()"
I'm leaving the status as CNR, since I only took a look at your coding style as I'm not familiar with the module itself.
If you need some help getting a patch created, drop into the #drupal or #drupal-ghop IRC channels on irc.freenode.net for some friendly advice.
Comment #6
webchickIndicating this needs work.
Comment #7
Mgccl commentedI got the patch it to work :)
see if the new one works.
Comment #8
jbrauer commentedThis looks like a good patch file.
The comments being sentences looks much better.
I'm not very familiar with the module so I'll leave it in needs review.
I did notice, however, that from a coding style that there are a lot of tabs where there should be two spaces. http://drupal.org/coding-standards
Comment #9
aclight commentedSetting to CNW due to tabs in the patch file.
Comment #10
aaron commentedBoth providers work perfectly! Great work! Other than the tabs, the only other piece that needs to be changed is to allow developers to set their own width & height for the player -- variables for these are already passed to the theme function, so you'd just need to invoke those when outputting the object, such as:
Also, the theme function allows for autoplay, although this depends on the providers, and may not be available for the players for odeo or podcastalley. In any case, that's outside of the scope of this task.
As soon as your patch file is up to Drupal coding standards and you've added the width/height variable support, I'd say this is RTBC.
Aaron
Comment #11
Mgccl commentedI have fixed all the spotted problem :)
Comment #12
jbrauer commentedLooks good from the coding standards standpoint.
Comment #13
aclight commentedI suspect this is now complete, but I'd like to get confirmation from aaron or Alex UA to make sure.
Comment #14
alex ua commentedI applied this patch and tested it on two different sites, and it works for me. Great job!
I'm marking this RTBC
Comment #15
aclight commented@Alex UA: Thanks for reviewing this. I've given the student credit for this task.
Comment #16
alex ua commentedThese were committed. THANKS!!!!!!
Comment #17
gusaus commentedI found this issue after some exciting discussion about integrating more audio providers (such as Last.fm) into Emfield (http://groups.drupal.org/node/9956#comment-32049) and thought it would be a great one to continue for DROP.
What might be cool?
http://www.programmableweb.com/api/last.fm
http://www.programmableweb.com/api/yahoo-music-engine
Support for external audio (embedding players, to even importing audio sets) opens up so many possibilities for users and developers.
Cheers!
Comment #18
joachim commentedHere's a provider for emaudio last.fm.
(Extension as txt so it attaches.)
Comment #19
alex ua commentedJoachim, thank you so much for this (though, comeon, doesn't this deserve its own issue?)! I'm a HUGE last.fm fan, so this is definitely going to make it into the full release. Question: is this for 5.x or 6.x?
Keep on rocking!
Comment #20
joachim commentedHi Alex! :)
This issue already mentioned last.fm audio support, so I figured better not spam the issue queue... :)
The inc file I posted is for 5, as I'm still developing for a 5 site.
And forgot to change status earlier... oops!
Comment #21
alex ua commentedI'm marking this as to be ported, as I'd like to see the support in 6 asap (I <3 Last.fm and will want this for a site I'm building). I'll try and port it soon, though I want to talk with Xano first to see if the provider file doesn't belong in that module.
Comment #22
aaron commentedwe're now moving all providers out of the module entirely.
Comment #24
joachim commentedHas anyone taken my lastFM code and released it as a module by any chance?