Fix coding standards issues with casetracker_dashboard module
Owen Barton - January 12, 2008 - 00:41
| Project: | Case Tracker |
| Version: | HEAD |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | won't fix |
Jump to:
Description
The attached patch fixes a whole bunch (343 to be precise) of coding standards issues with casetracker_dashboard. Following this patch it now gets a clean bill of health from coder module. I haven't (that I know of) made any logic changes at all, this is pretty much all just correcting indentation and code style.
This would be a pain to have to reroll, so if we could get this in before making any other commits to casetracker_dashboard that would be great :)
The rest of casetracker has some coding standards issues too, but they are much more limited - the dashboard module stood out as particularly bad, so I thought I would start with this.
| Attachment | Size |
|---|---|
| casetracker_coding_standards.patch | 18.36 KB |
#1
Sadly the patch no longer cleanly applies and casetracker_dashboard is not going to exist as it does now moving forward.
I'm setting this to "won't fix" as there are no plans to return to casetracker_dashboard's current code at all - but if the patch gets re-rolled I'd be happy to commit.