I have the latest tinymce CVS and latest img_assist CVS running with Drupal 4.6 and I'm using Internet Explorer (pain-inducing browser, I know). There are just two minor issues with inserting images using the plug-in camera icon:

The first time I open the img_assist window, nothing loads into the pop-up window, so I close the img_assist pop-up and click on the camera icon again. Now, the "add image" and other nav buttons load, along with thumbnails of any loaded images. I'm ready to go and everything works from here. It would be nice though, if I don't have to open img_assist twice to get it working.

Also, in connection with another post about the original img_assist button, it would be desireable, I think, if this button was not visible (or clickable) when the tinymce version (the camer icon) is loaded. I'm sure all of this is a bit of a trick (the other post is addressing access permissions for img_assist). But this button also doesn't work properly when tinymce is loaded, so it would be best if it went away when the tinymce plugin support is detected.

CommentFileSizeAuthor
#8 img_assist-head-fix_0.patch1.17 KBsyllance
#6 img_assist-fix_0.patch1.61 KBsyllance

Comments

bomarmonk’s picture

bomarmonk commented
Priority: Minor » Critical

Okay, I'm still working with the latest Tinymce module ($Revision: 1.34 $) and Img_assist module ($Revision: 1.46 $) with Drupal 4.6.2 and tinymce release 1.45.

In Internet Explorer or Firefox, clicking on the original img_assist button produces the expected pop-up window and preview pane as expected.

In Internet Explorer or Firefox, clicking on the "camera" button for the tinymce plugin produces the message: "this window has lost communication with its parent form ,so images can no longer be inserted...." If I hit cancel, the expected pop-up window and preview pane loads. Not too bad.

However, inserting an image no longer works at all with either method (hence the upgrade of this issue to critical). I get the error: line 56, char 7, 'edit [thumpath]' is null or not an object, code: 0, http://www.mysite.com/modules/tinymce/tinymce/jscripts/tiny_mce/themes/a.... (firefox reports no error and does nothing-- no image inserted).

This is a fresh install of both tinymce and img_assist. I guess this could be a configuration issue, but I've checked the usual folder permissions and made certain pop-up blockers are disabled.

matt westgate’s picture

matt westgate commented
Assigned: Unassigned » matt westgate
Priority: Critical » Normal

I'm unmarking this a critical since this is HEAD and not an actual release.

The problem is with the latest upgrade I made to img_assist. I'll try and get that resolved today.

bomarmonk’s picture

bomarmonk commented

Thanks! Sorry if my labelling of the issue wasn't right. Protocol often eludes me, but I'm working on it.

matt westgate’s picture

matt westgate commented

Please update tinymce and img_assist. It should be working now. Note: I did not update the camera button plugin yet.

bomarmonk’s picture

bomarmonk commented

I updated both tinymce and img_assist and I'm still having some issues: with the camera button I get, "my text-area is undefined." No image is inserted-- you've suggested that this button isn't fixed yet, so this probably isn't news

With the orginal button, though, it works pretty well, but the image preview in tinymce just shows up as a broken image with the red-x in it.

Much better, but still some things are broken. Thanks for the great modules, once again.

syllance’s picture

syllance commented
Version: » 4.6.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new img_assist-fix_0.patch1.61 KB

please find attached a patch that fix the camera button issue (typo in variable that stores the textarea name), and the broken image thing when you insert html (added call to file_create_url).

this patch is for 4.6, not (yet) head. will send another patch later.

matt westgate’s picture

matt westgate commented
Version: 4.6.x-1.x-dev »

Patch applied. Can you cook up another patch for HEAD? Thanks!

syllance’s picture

syllance commented
StatusFileSize
new img_assist-head-fix_0.patch1.17 KB

here it is.

this is a pre form api patch, and it only contains fixes already applied for 4.6.

i'm working on the form api upgrade for img_assist, and will post it on another issue/patch.

matt westgate’s picture

matt westgate commented
Status: Needs review » Fixed

Fixed. Thanks!

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)