Adding the name of the project to the subject of the mails sent by them module would help scanning these mails.

Something in the lines of
[drupal-devel] [Image] Database errors
is much more informative then
[drupal-devel] Database errors

Should be simple to do, I guess :)

CommentFileSizeAuthor
#6 project_title_in_emails_1.diff666 bytesBèr Kessels
#2 project_title_in_emails_0.diff676 bytesBèr Kessels
#1 project_title_in_emails.diff668 bytesCvbge

Comments

Cvbge’s picture

Cvbge commented
StatusFileSize
new project_title_in_emails.diff668 bytes

Didn't tested this task, still don't have Project running on localhost ;)
This patch adds [
] at the beginning of subject, so subject would be:
[Image][bug]Database errors

Bèr Kessels’s picture

Bèr Kessels commented
StatusFileSize
new project_title_in_emails_0.diff676 bytes

[22:40:36] exclude: perhaps it's better to have [Image bug] rather than [Image][bug]

this patch does that. And it also does better translation. stuff like [ ]'s should not be in the translation

Cvbge’s picture

Cvbge commented

@Ber: you should not t() project's title.

Bèr Kessels’s picture

Bèr Kessels commented

Why not? I did this intentional, but think you have a good reason not to want that t()-ed. could you share that reason?

Cvbge’s picture

Cvbge commented

First of all, project title is user provided, and AFAIK there is a policy not to translate user input.

Second reason is that I think project name is a proper noun (like Ber ;) and should not be translated.

I don't know, but I suppose there might be problems with this information not being translated in other places (e.g. url: user see in mail [Zdjęcie Bug] (Zdjęcie == t("Image")) so he goes to /project/Zdjęcie but there is no such project...)

Bèr Kessels’s picture

Bèr Kessels commented
StatusFileSize
new project_title_in_emails_1.diff666 bytes

yup. correct. new patch attached

Bèr Kessels’s picture

Bèr Kessels commented
Status: Needs review » Reviewed & tested by the community
nedjo’s picture

nedjo
he/him/his
Primary language English
commented

Let's apply this. It's a significant improvement, particularly because it would enable easy filtering by project.

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Thanks for the improvement, applied.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)