Javascript show/hide not working in IE6/7

bsuttis - January 15, 2008 - 23:39
Project:Conditional Fields
Version:5.x-1.x-dev
Component:Javascript
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed
Description

I've got this working just fine in FF 2, but on both a fresh install of 5.5 and a production site running 5.1 in IE6/7, selecting the conditional value that should display the hidden field doesn't work.

I'm guessing this is just a javascript discrepancy? Anyone have fields showing/hiding in IE6/7?

#1

bsuttis - January 15, 2008 - 23:40
Version:5.x-2.x-dev» 5.x-1.x-dev

Version was wrong =/

#2

christefanø - January 29, 2008 - 00:44
Priority:normal» critical

I can confirm that it doesn't work in IE 6.

#3

peterpoe - January 30, 2008 - 20:17

I could use some help with this issue, since I don't have easy access to a Windows machine... Anyone else confirming the bug?
Are the fields not hidden, or not shown? Does this happen with every type of controlling field (checkboxes, radios, select, multiselect)?

#4

christefanø - January 30, 2008 - 20:36

The fields aren't shown at all when the controlling field is selected. In my case, it was an "Other" checkbox that shows a "Other (please describe)" textfield.

I can do more testing soon.

#5

dragoff - January 31, 2008 - 04:49

Tested with IE6 & IE7 (checkbox, radio button, select) - the controlled fields does not show at all. By the way- thanks a ton for the great module :]

#6

scottrigby - February 3, 2008 - 01:07

I'll be happy to test once a patch is proposed - and I'd be using this module right now on a site except a ton of people who this site appeals to will be using IE :(
Thanks though - looking forward to patches / further releases!

#7

peterpoe - February 4, 2008 - 16:40
Status:active» patch (code needs review)

The bug was due to IE not executing the jQuery change event. Maybe this is a jQuery bug? Anyway, I added a switch that ensures that a click event is added with IE (other browsers still use the change event). This could cause other problems, so we have to test the fix thoroughly.

The attached patch is against conditional_fields.js v1.1.2.10.
You can download the patched conditional_fields.js (1.1.2.11) from the latest CVS.

NOTE: the patch was tested ONLY on IE7. Could anyone please test on IE6?

AttachmentSize
conditional_fields.js IE patch3.62 KB

#8

bsuttis - February 5, 2008 - 01:58

From my limited testing, it appears to work correctly in IE6/7 and Firefox 2.

#9

peterpoe - February 19, 2008 - 16:05
Status:patch (code needs review)» fixed

No more reported errors in 2 weeks. I'll mark this as fixed.

#10

Anonymous (not verified) - March 4, 2008 - 16:12
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

#11

patchak - April 24, 2008 - 12:54

Hey there, was this added to a new release of the module?? We should use the dev version??

#12

patchak - April 24, 2008 - 12:55
Status:closed» active

re-opening to have more infos about this....

#13

peterpoe - April 24, 2008 - 13:07
Status:active» closed

Jep, the patch is in the latest dev. Re-closing.

 
 

Drupal is a registered trademark of Dries Buytaert.