Project node teasers are different when filtering by a version

Yup. Weird. I don't know what would be causing that, but it's a problem in the drupal.org theme ("bluebeach"). I think it was killes who added those project thumbnails originally, perhaps he knows what the filtering might have to do with it. Certainly, the download links change when you filter... there's no longer a download table, but a single "download" link. Maybe he tied the thumbnail to the download table somehow?

Actually no, it is a project* problem. The module uses a different theme function for output when the users filters the output.

Uhh, no it's not... Look in project.module and tell me where you think this is happening. I see the following on line 812:

    $projects .= theme('project_summary', $project);

That's called regardless of version filtering. There are different theme functions called if the table is present or not, since the download link is one theme function and the download table is another. But, as far as I can see, theme('project_summary') is called in both cases. It's entirely possible there's some other problem, but separate theme functions isn't it. For example, perhaps the $project object being passed in (which is *not* a fully node_load()'ed node object) has different fields in the two cases, and that's somehow confusing the image_attach code in the theme function?

Yeah, I was wrong there, it must have to do with not the same fields being present.

It is a bit stange as the template only requires the node ID to find the attached image...

@killes: could it be the caching of project_page_overview: that's locally installed on d.o? Should we completely flush that cache on d.o and see if that helps?

side note: it's a pain that's a local patch on d.o. we should really commit that "upstream".

I don't think this is related to the patch.

You are free to take the patch and apply it. You thought it was ugly, though.

http://drupal.org/node/234934 was duplicate.

We've had a few duplicates of this issue recently (such as #237839: Filtered project list shows unsupported releases), so I'm changing the name of this issue to better reflect what is happening.

Inviting people to download unsupported releases is more than a cosmetic problem (like thumbnails not showing)!

Since this has lingered for two months, I'm upping priority and moving the issue where cwgordon7 moved my duplicate (#237839: Filtered project list shows unsupported releases).

It does look like the filtered view simply takes an old code path that hasn't been updated.

I don't think the problem of having development snapshot releases show up when the project overview page is not filtered (if this is even to be considered a problem) is due to the project module itself. On a clean install on a site using the drupal.org testing installation profile, I don't see snapshot releases on the project overview page regardless of whether or not I am filtering by version.

I'm putting this back in the infrastructure queue, since my best guess is that bluebeach is overriding theme_project_summary() and the override is specifying that development snapshots be included in the table.

If someone with access to bluebeach can send me the override of theme_project_summary(), if one exists, I could take a look at this and at least confirm that the theme is causing this.

function phptemplate_project_summary($project) {
  $image = module_invoke('image_attach', 'nodeapi', $project,  'load', TRUE, FALSE);
  $has_image = FALSE;
  if (isset($image['iid']) && $image['iid']) {
    $project->iid = $image['iid'];
    $has_image = TRUE;
    module_invoke('image_attach', 'nodeapi', $project,  'view', TRUE, FALSE);
  }
  $output = '<div class="project-item project-'. preg_replace('/[^A-Za-z0-9]/', '', strtolower($project->term)) . ($has_image ? ' project-with-image' : '') .' '. $project->class .'">';
  $output .= '<h2>'. l($project->title, "node/$project->nid") .'</h2>';
  if ($has_image) {
    $output .= $project->content['image_attach']['#value'];
  }
  $output .= $project->body;
  if ($project->download_table) {
    $output .= $project->download_table;
  }
  $output .= '<div class="links">'. theme('links', $project->links) .'</div>';
  $output .= '</div>';
  return $output;
}

I don't think the problem of having development snapshot releases show up when the project overview page is not filtered (if this is even to be considered a problem) is due to the project module itself.

The problem I reported in #237839: Filtered project list shows unsupported releases is very different from what you're summing up here. I'm not convinced it's a theming issue, either, and it wasn't my idea to mark it as a duplicate of this one...

Hint 1: UNSUPPORTED development snapshot release vs. supported development snapshot release

Hint 2: the issue occurs when the page IS filtered.

It turns out that in project_page_overview(), n.type was only being included in the query if the release filter was set to all. Image attach won't attach an image to a node if it doesn't know the node's type, and so in the teaser view with the project version filter set, no image was attached. This simple patch fixes the problem on a local test site.

This patch has found to be working and was deployed on d.o.

Ahh, makes sense. Reviewed and looks great. Committed to HEAD and DRUPAL-5. Thanks!