Port of AdSense to 6.x

Might be an idea to mention it here: http://groups.drupal.org/node/5036

Before the 6.0 port can happen, we need to fix the new Adsense code issue here http://drupal.org/node/195036

Ok. I mentioned it on that other page.

Issue http://drupal.org/node/157039 had some code for 6.x, but it needs to things:

- Validation that it works with the final release of D6. A lot has changed from July to January.
- Inclusion of the above issue (new Adsense code) before we move to D6.

Good luck guys in creating the port for Drupal 6.

Any idea when this module is available for 6.x ??

See #3 and #5.

It would be nice if people jumped in and contributed patches or tested existing patches too.

Hello,

this is a reply to #5

I tried out that code just now (see that link for the results), so that code seems to work/not break Drupal 6.1 .

now, how would I go about step 2, including that new adsense code?

Kind regards

Gijs

The Step 2 you mention basically means that, until the issue mentioned in comment #3 is fixed, there will be no Drupal 6.x version. As for information on how to fix it, see the link in comment #3.

As I said in the other issue, which you seem to have not read my replies in ...

1. The D6 code in the other issue is 6 months before the actual D6 was released, so it should be avoided/updated.

2. There are lots of stuff that went into the D5 version (specifically 5.x-2.x) and we can't leave that out.

3. The updated Google code is a crucial issue. We sure need that in D5 now before branching to D6, otherwise it will be too much work to go back and fix it. If people test the patches that ALREADY CREATED, then we will get this over with and people can move on to D6.

So, there you have it ... any other bright ideas?

I was assuming that Gijs had tried the other code all forward-ported and everything. I realise now that this probably wasn't the case. My apologies.

adsense 5.x-2.x-dev patch for D6 with coder clean up.
menu should not yet complete, $may_cache part not yet revamp with hook_init().

bug: not able to create adsense_click table, not able to access adsense admin page.
any idea and input?

Just applied the patch to the 5.x code that was developer released a couple days ago. It loads but I don't get anything showing up in site configuration. When I run update.php I get the following error:

Failed: ALTER TABLE {adsense_clicks} ADD `path` VARCHAR(255) NOT NULL DEFAULT ''

Patch via DRUPAL-5--2, test with adsense.module and adsense_basic. Include coding style clean up and update with coder. Please test with complete uninstall and reinstall.

Able to work with Google Adesnse Injector (http://drupal.org/project/adsense_injector, http://drupal.org/node/223099).

Some minor coding style update.

I appreciate all the effort going into this, but please remember that 5.x-2.x had some changes in it and needs to be tested for the new Adsense code.

Even if we have a 6.x branch working, it will require work to merge changes from 5.x into it.

Therefore focusing on a stable 5.x is a faster way to get 6.x out ...

Please go to the issue linked above and test the 5.x-2.x-dev tarball and make sure everything is working.

Only after that is done, we can use this as a base for 6.x.

Noted,

Unfortunately, my site runs on v6.1 so I don't have much choice but to try whatever I can to get this working as quickly as possible.

Sorry if it is a dumb question; how do we apply the patches to our codes exactly?
Thank you so much.

turco, try a google search for "drupal how to test a patch" -> http://www.google.pt/search?q=drupal+how+to+test+a+patch

You'll find what you need.

Raul

kbahey, I have been using the 2.x branch for quite some time and everything seems to be working fine.

Where else can I help in order to declare 2.x stable?

By the way, thanks for the great module! ;)

Raul

borfast,

Thanks for the feedback. I just need two or three more people to do the same (using 5.x-2.x-dev without issues, and the old and new code works for them), then we can close the 5.x chapter and move to 6.x.

kbahey - I will begin testing 5.x-2.x-dev on a multiuser site today (Your2ndplace.com) and will give feedback as well. Since that site has multiple authors and uses the sharing, it will be a pretty solid test.

Stand by for heavy rolls in high seas. ;-)

Thanks Taran ...

/me holds tight to the gunwale ...

Hi, I use 2.0 for more than 2 weeks, everything is ok. Please let me know if you want to do any special test.

The testing needed is for 5.x-2.x-dev not 5.x-2.0.

Thanks.

I will test it this weekend.
Could we also solve this issue http://drupal.org/node/220770 before porting to 6.x?

I would prefer not to..

We can't honestly hope to solve all the problems in 5.x before the move to 6.x. That will only postpone it indefinitely.

João

@jcventura

I am not asking to solve all issues for 5.x. We have one main specific issue 195036.

Issue 220770 is nice to have, but not essential before the 6.x port.