Adsense revenue sharing does not work when page caching is on

Evident.
You wrote:

So, whatever the Adsense ID happens to be when the page got cached, this will be served to the visitors until the cache expires (duration expires, or new content/comment gets posted).

What empties cache when I set a cache duration - and no content/comment is posted or edited?
Will drupal check cache time before he delivers the site? Or does cron check this and empties the cache when duration is expired?
(I thougt cache duration is only for high traffic sites. P.e. when every minute a comment is posted, I set a cache duration for 10 minutes. So cache will be emptied only every 10 minutes. But when I have a site where nothing changes over 3 days, cache will not be emptied before I edit or post some content/comment).

Will this be the same in drupal 6?

When drupal 6 will have the same cache mechanism, a solution would be fine.

My idea is to set cache duration to one hour - so every hour the dice rolls for the Adsense-Client-Id.
So I can enable cache and be sure that revenue is shared.

But what happens, if nothing is changed on a site for several days. Will cache be emptied or not?

I think cache mechanism works like I described here: http://drupal.org/node/142242#comment-235668

If I'm right and if nothing is changed on a site, there is no way for the Drupal core to know that cache has expired, and old content will be held in the cache.

So to be sure that cache is emptied after an hour, I have to write a module that uses hook_cron to call cache_clear_all(), described here: http://drupal.org/node/103995#comment-181373
and I have to run cron every hour. Right?

I think it's a valid method for revenue sharing to throw the dice for the Adsense ID every X minutes. So it can go into the module.
And I think it's a good solution to the cache problem. It also could be an example to solve the similar problem using tags inside content with caching.

It should go into revenue_sharing_basic.module, cause it's only needed for revenue sharing:

--Revenue sharing options--

X Enable revenue sharing
Note that enabling this will disable AdSense code caching, which
~ Note that revenue sharing is not working reliably when cache is enabled. Disabling cache can cause more resource usage for busy sites. The referral feature requires the referral module to be installed.
(or did you really disable caching?)

Enforce cache flush
0-X minutes
~ If cache is enabled, you can flush the cache to throw the dice for the Adsense ID...
+ a hint what happens, if cache duration is enabled

Percentage of node views going to author:
50

+1

A solution for this is needed!

*subscribing

Here is a patch. But it does not work: revenue_sharing_basic_init() is not called for anonymous users - only when I'm logged in.
I don't know how to fix this.
(I added 45 minutes cause min-cache-duration also has this option.)

kbahey, I use normal caching.

And I see the notice: "The following enabled modules are incompatible with aggressive mode caching and might not function properly: path_redirect, revenue_sharing_basic, token."

Subscribing, I will test adsense 2.dev with revenue sharing, greetings, Martijn

Can I do something to solve this issue? Please, let me know.

subscribing

(a small comment: GoogleAds generates income only on relatively high-traffic sites And the speed of pageloads in essential. So it makes sense to have a caching compatibility for Revenue Sharing. I tried Revenue Sharing, but had to disable it _only_ because disabling my Normal caching made my pageloads slower and very user-unfriendly)

This seems to be impossible to handle.. If Drupal's cache is enabled, then it will store an 'image' of the page when it last served it, and it will keep re-using that page from cache until it expires or the page is modified.

The only way to make this work would be to invalidate the cache all the time. Which would make it useless to have cache enabled in the first place.

This can be reactived later on if someone finds a way to modify a page after it is retrieved from the cache, but before being sent to the user's browser.

Will using ajax solve this problem?

Hi,

I believe I've solved this problem for cached pages by using ajax. I've tested and it works on normally cached pages. Attached is a patch for review.

In a nutshell here's how it works:

1. If user is anonymous, in the adsense_display function (adsense.module) we run a different function:

if ($user->uid) {
  // User is logged in.
  $ad = _adsense_oldcode_get_ad($args['format'], $client, $args['group'], $args['channel']);
} else {
  $ad = _adsense_oldcode_get_ad_anon($args['format'], $client, $args['group'], $args['channel']);
}

2. In the new function, _adsense_oldcode_get_ad_anon, we insert some js inline into the header that will create an ajax call back to revenue_sharing_basic.module to fetch the publisher id and set it as a global js variable.

	// First add the ajax function to the header as inline js.
	// Note we need to tack the node id to the end of the 
	// callback (ajaxURL) so we can track down the author
	// when the function is called. This works for both regular nodes
	// and panel pages. If no argument is present, the function
	// will return the default publisher id.
	if ( arg(0) == 'node' && is_numeric(arg(1))) {
		$path = 'pub_id_anon/' . arg(1);
	} else {
		$path = 'pub_id_anon';
	}
	drupal_add_js('
						var ajaxURL="' . url($path, null, null, true) . '";
						var pub_id;
						function loadPubID() {
							pub_id = $.ajax({
						      url: ajaxURL,
						      async: false	
						  }).responseText;
						}
						loadPubID();
					', 
					'inline',
					'header');

In this same function, when we embed the google embed code, we reference the global js variable as follows:

google_ad_client = "pub_id";

3. Created a new menu callback in revenue_sharing_basic.module (called by the ajax above). This in turn calls a slightly modified revenue_sharing_basic_choose_client function that now accepts node_id as an optional argument and returns a json formatted publisher id.

function revenue_sharing_anon_pub_id($node_id = NULL){

	// Retrieve the publisher id. If $node_id is empty, 
	// returns default publisher id
	$reply = revenue_sharing_basic_choose_client($args,$node_id);	
	print drupal_to_js($reply);
	exit();
}

I've also added an administration testing setting that let's you see the publisher_id that get's returned.

Some important points.

1. Patch is rolled against the 5.x-3.x-dev 2009-Sep-02 release
2. This whole routine only works if you are logged out.
3. This setup requires that all of your js be loaded in the head of your page. Otherwise the google ad embed will load first and reference an undefined variable.

Feedback is welcome though my time is very limited at the moment.

Hi,

The 'adsense_anonymous_test_mode' setting is completely unnecessary, the existing 'adsense_test_mode' is completely adequate for this also.

Why does the new function duplicate all the existing ad generating code from the managed ads module? Why aren't you re-using that code?

Finally, there's too much duplication inside revenue_sharing_basic_get_node_info().. I think that modifying this function to always accept the $nid parameter would improve the code a bit.

João

subscribe

The solution for this should be something like the Ajax Blocks module.

This version of AdSense is not supported anymore. The issue is closed for this reason.
Please upgrade to a supported version and feel free to reopen the issue on the new version if applicable.

This issue has been automagically closed by a script.