Hi,

I have alredy installed adsense 5.x-1.6 and upgraded this to version 5.x-2.x-dev.

Befor the upgrade revenue sharing works fine for me. After the Upgrade is used by the module merely the Adsense Client ID of the user 1 in the Adsense-code and never the ID from Content-author.

Even with the following setting: Percentage of node views going to author: 100%.

Please, says to me what I could have overlooked or fix this problem.

Thanks
Frank

CommentFileSizeAuthor
#4 revenue_sharing_basic.module.txt8.33 KBkbahey

Comments

kbahey’s picture

kbahey commented
Priority: Critical » Normal
Status: Active » Postponed (maintainer needs more info)

Which selection module did you chose? adsense_basic or revenue_sharing_basic?

If you want revenue sharing you have to select the latter.

Also, there are upgrade instructions for it at http://drupal.org/project/adsense

Make sure you read it and apply it, then see if you have issues still.

frank.dev’s picture

frank.dev commented

I chose revenue_sharing_basic.

http://drupal.org/project/adsense

"Upgrading

If your site already uses revenue sharing, you need to first write down the revenue sharing settings, before installing the 5.x-2.x version of Adsense. You then need to enable the Revenue Sharing Basic module, and click on its Settings, and enter all the settings that you wrote down earlier."

I have done exactly this. ;-)

kbahey’s picture

kbahey commented

OK, we have a bug then.

Can you join me on IRC? Free node #drupal-dev. My nick is kbahey.

kbahey’s picture

kbahey commented
Status: Postponed (maintainer needs more info) » Fixed
StatusFileSize
new revenue_sharing_basic.module.txt8.33 KB

I found the problem and fixed it.

The attached file is a modified version. Download it, rename it to .module (remove .txt), and it should work fine.

Also committed to 5.x-2.x-dev, but will take some time to make it there.

frank.dev’s picture

frank.dev commented
Status: Fixed » Active

Thank you kbahey, I have installed 5.x 2.x dev with the modified version from "revenue_sharing_basic.module".

On the first sight this also functioned revenue_sharing. But... If I activate the caching mode for the Drupal-site (Administer >> Site configuration >> Performance: Caching mode: "Normal"), it is indicated again generally the Adsense client ID of a user - revenue_sharing does not work.

All the same which setting I choose - "Percentage of node views going to author: 5 - 90" - it is always the same result. Either is indicated generally the Adsense client Id of the Site owner or the author.

If I disabled the cache, the indicated ID's alternate in the source correctly.

kbahey’s picture

kbahey commented
Status: Active » Fixed

That is a separate issue.

Closing this and opening a new issue for it here http://drupal.org/node/220770.

frank.dev’s picture

frank.dev commented

Hi kbahey!

Ok, I understand. Many thanks for your help - and for the new feature request.

Frank

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.