Port to 6.x
rayarub - January 18, 2008 - 15:18
| Project: | Audio |
| Version: | 5.x-2.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | patch (code needs work) |
Description
Is anyone working on a Drupal 6 port yet?
#1
I'd like this one to be ported as well.
#2
marked http://drupal.org/node/214915 as a dupe
#3
Any new news? Thanks.
#4
Guys, i really need this module ported, is there somebody working on it?
#5
Would it be possible for a developer to give us some kind of update on this? Thanks.
#6
marked http://drupal.org/node/235588 as a duplicate
#7
I would appreciate very much if someone is working on this. Any info or comments, please.
#8
Any sign of a 6.x version of this module?
#9
hmmmm, over 2 months and no response - anybody with skills considering a port as a patch? i have no idea how to do it though would love to see it happen...too bad. there are a LOT of d6 sites that can not go up without audio module because they can't migrate their podcasts and other related items...
#10
Audio module was the reason why I selected Drupal in the beginning. Now that reason seems to fade away ...
#11
I'm too looking forward to get this module working. Does anyone knows anything about future of this module?
#12
This needs lots and lots of work, but it's a start if anyone wants to continue. Here's a summary of progress:
node/add/audiodoesn't work, which is a pretty big impediment to further progress. The node form renders fine, but if you submit it, it just takes you back to the add page as if nothing happened. I've thrown a couple of FIXMEs in where I know something isn't right yet.Patch is against CVS head.
#13
Ahhh...any progress on this?
#14
I see the problem with your node submission.
hook_submit()has been removed. You need to add it as an extra submit handler to the form now. I'm currently testing a fix; will post a new patch here if it works.#15
I have just created an audio node using my fix.
The "click to play" link is broken without clean URLs (it produces a link like
?q={site_base}?q=audio/play/1), and the file transfer doesn't actually work (audio_file_transfer()tries to close a non-existing output buffer, and audio/play/n returns 404), but I've been able to save the node, at least.I'm sorry, but I only have jEdit here and it won't let me print a unified diff. This isn't a "real" patch anyway, but a patch on the new files uploaded above - a "patch-patch".
836a837,839>
> // Register the submit hander.
> $form['#submit'][] = 'audio_node_submit';
908c911
< * Implementation of hook_submit().
---
> * Node submit handler
910,912c913,915
< function audio_submit(&$node) {
< // If a new file was stored in the session move it into the $node.
< $nid = ($node->nid) ? $node->nid : 'new_node';
---
> function audio_node_submit($form, &$form_state) {
> // If a new file was stored in the session move it into the $form_state.
> $nid = ($form_state['values']['nid']) ? $form_state['values']['nid'] : 'new_node';
914,915c917,918
< $node->audio_file['file_path'] = $_SESSION['audio_new_file'][$nid];
< $node->audio_file['newfile'] = TRUE;
---
> $form_state['values']['audio_file']['file_path'] = $_SESSION['audio_new_file'][$nid];
> $form_state['values']['audio_file']['newfile'] = TRUE;
#16
Excellent, thank you. I will incorporate that fix in the next couple days. Can you repost that diff in the usual patch format (
diff -up)?#17
Unfortunately I don't have a diff utility on the computer I'm currently using, and jEdit will only print the above format.
#18
I'll test this once there is a patch made in regular format.
Thanks so much to HorsePunchKid and Arancaytar!
Shai
#19
Are there any fixes available for 6.2?
#20
HorsePunchKid, are you on this? I don't want to bother diffing all the files without making more substantial changes, but I could try to solve the other problems (the clean URL redirect and the download links, for example).
#21
subscribing.
#22
. I am expecting this to be in drupal6! thank you all!
#23
great work guys. I'm available for testing a beta module when it's ready.
#24
I can start working on this around June, if nobody else takes it up.
#25
looking forward to a Drupal 6 version, I can't upgrade until this great module is updated. Thanks to those in the community who have the ability and time to make this happen!
#26
I made the changes in #15 against the tarball in #12 and re packaged it. I made the changes by hand so it would be good if Arancaytar could look it over and make sure they are right. I'll try installing this in my dev site and see how it works and report back. I'm not the greatest with php code but I'll see if I can work on this a little in my "spare time".
#27
Tried using the package from #26 & got this message:
Fatal error: Call to undefined function file_check_upload() in /home/cinemasa/public_html/modules/audio/audio_images.module on line 146.
So more work to be done, but thanks for the effort. We all want/need this for 6.
#28
I am getting the same error with the package from #26
#29
Here's what someone did to the image module to fix this problem, get your hints from there.
http://drupal.org/files/issues/image-d6upgrade-181809-32.patch