Audio Port to 6.x

I'd like this one to be ported as well.

marked http://drupal.org/node/214915 as a dupe

Any new news? Thanks.

Guys, i really need this module ported, is there somebody working on it?

marked http://drupal.org/node/235588 as a duplicate

I would appreciate very much if someone is working on this. Any info or comments, please.

Any sign of a 6.x version of this module?

hmmmm, over 2 months and no response - anybody with skills considering a port as a patch? i have no idea how to do it though would love to see it happen...too bad. there are a LOT of d6 sites that can not go up without audio module because they can't migrate their podcasts and other related items...

Audio module was the reason why I selected Drupal in the beginning. Now that reason seems to fade away ...

I'm too looking forward to get this module working. Does anyone knows anything about future of this module?

This needs lots and lots of work, but it's a start if anyone wants to continue. Here's a summary of progress:

• Almost completely passes tests in coder.module.
• All of the modules should install and uninstall cleanly, including upgrading.
• The settings forms mostly work.

node/add/audio doesn't work, which is a pretty big impediment to further progress. The node form renders fine, but if you submit it, it just takes you back to the add page as if nothing happened. I've thrown a couple of FIXMEs in where I know something isn't right yet.

Patch is against CVS head.

Ahhh...any progress on this?

I see the problem with your node submission. hook_submit() has been removed. You need to add it as an extra submit handler to the form now. I'm currently testing a fix; will post a new patch here if it works.

I have just created an audio node using my fix.

The "click to play" link is broken without clean URLs (it produces a link like ?q={site_base}?q=audio/play/1), and the file transfer doesn't actually work (audio_file_transfer() tries to close a non-existing output buffer, and audio/play/n returns 404), but I've been able to save the node, at least.

I'm sorry, but I only have jEdit here and it won't let me print a unified diff. This isn't a "real" patch anyway, but a patch on the new files uploaded above - a "patch-patch".

836a837,839
>   
>   // Register the submit hander.
>   $form['#submit'][] = 'audio_node_submit';
908c911
<  * Implementation of hook_submit().
---
>  * Node submit handler
910,912c913,915
< function audio_submit(&$node) {
<   // If a new file was stored in the session move it into the $node.
<   $nid = ($node->nid) ? $node->nid : 'new_node';
---
> function audio_node_submit($form, &$form_state) {
>   // If a new file was stored in the session move it into the $form_state.
>   $nid = ($form_state['values']['nid']) ? $form_state['values']['nid'] : 'new_node';
914,915c917,918
<     $node->audio_file['file_path'] = $_SESSION['audio_new_file'][$nid];
<     $node->audio_file['newfile'] = TRUE;
---
>     $form_state['values']['audio_file']['file_path'] = $_SESSION['audio_new_file'][$nid];
>     $form_state['values']['audio_file']['newfile'] = TRUE;

Excellent, thank you. I will incorporate that fix in the next couple days. Can you repost that diff in the usual patch format (diff -up)?

Unfortunately I don't have a diff utility on the computer I'm currently using, and jEdit will only print the above format.

I'll test this once there is a patch made in regular format.

Thanks so much to HorsePunchKid and Arancaytar!

Shai

Are there any fixes available for 6.2?

HorsePunchKid, are you on this? I don't want to bother diffing all the files without making more substantial changes, but I could try to solve the other problems (the clean URL redirect and the download links, for example).

subscribing.

. I am expecting this to be in drupal6! thank you all!

great work guys. I'm available for testing a beta module when it's ready.

I can start working on this around June, if nobody else takes it up.

looking forward to a Drupal 6 version, I can't upgrade until this great module is updated. Thanks to those in the community who have the ability and time to make this happen!

I made the changes in #15 against the tarball in #12 and re packaged it. I made the changes by hand so it would be good if Arancaytar could look it over and make sure they are right. I'll try installing this in my dev site and see how it works and report back. I'm not the greatest with php code but I'll see if I can work on this a little in my "spare time".

Tried using the package from #26 & got this message:
Fatal error: Call to undefined function file_check_upload() in /home/cinemasa/public_html/modules/audio/audio_images.module on line 146.

So more work to be done, but thanks for the effort. We all want/need this for 6.

I am getting the same error with the package from #26

Here's what someone did to the image module to fix this problem, get your hints from there.
http://drupal.org/files/issues/image-d6upgrade-181809-32.patch

I modified the audio_image.module by editing the line which contanied the file_check() function and the problem seemed to dissapear.

- if ($upload = file_check_upload('image')) {
+ $validators = array(
+ 'file_validate_is_image' => array(),
+ );
+ if ($upload = file_save_upload('image', $validators)) {

I am not an expert programmer so it is likely I'm doing something really wrong, and the page still spit some errors about getid3 about not getting the tags for file "". And the audio node is created but nothing can played.

So... any news on this?

subscribe

subscribing. have installed #15... not yet working.

subscribe

Are there alternatives?

does I can help ???

I've 2 years experience in C#... think that I can do something...

That would be great! We're all looking forward to this.

Sorry, but although I want help, I'm asking permission to drewish...

please, 'u need understand... he's the creator...

I'm sure he'd be fine with it. It is an open source community after all. The point is to make is to make it work. Thanks for your help, I'm really eager to start using this module.. I have a lot of great stuff waiting to go.

Even though I'm fairly new to drupal and php as I'm developing/ building some band's site I would offer any help I can to port this module to D6. And may it be testing. This is the only module I'm planing in using that is not yet available for D6. Thanks for everyone's effort on this port so far!

i created a DRUPAL-5--2 branch so that the D6 work can happen in HEAD now. I've gone ahead and committed the work that HorsePunchKid and Arancaytar did. it should make it easier to see what subsequent patches change. there's still some big bits to get working so i'll leave this issue open.

i had some time this afternoon and banged around on the update a bit. uploads seem to be working player theme functions are now registered. it actually looks like the module will be a lot smaller when this all done... i'd had a lot of cruft code to get the previews working and it seems like the forms api updates have made a lot of that code unnecessary.

I am testing this out for Drupal 6 and things are looking good. I have imported files and played them successfully. The player works well!

I'm testing this on Drupal 6.2 and can import audio files and create nodes. However, I can't seem to get any of the players working. I recall in the 5.x version that under Audio Settings was a tab to choose which player to use but I don't see that option now. Thoughts?

same here (D6.2 also and no play back, player selection or any of that kind)

there are definitely some problems with the menus. not sure about the players, for testing you might try disabling the audio_getid3 module and see if they work then, i haven't gotten into that code yet.

thanks for your fast reply. I'll report what I find out when I get to including adio into the side I need it for (which might take a couple of days).

thomas23@drupal.org, be very careful with it, it's pretty broken.

My initial problem with the player was that I imported audio into Drupal without first installing the getid3 stuff, so the file was messed up. Either that or the file was incompatible with the player. Once I took care of both of these, the audio played well with a nice player interface.

I'm using it, and I see the player, but cannot get the playlist or images working. Any idea when this functionality might be coming online? Thanks again.

Thanks for pointing out, drewish, but I'm aware of that. After all, it's for some small site :)

I don't know if this is only new to me but I'll share it anyway:

There's currently a bug in Firefox 2.0 and people are reporting similar problems in Opera. In IE7 this isn't a problem.

The bug:

If you set the width and height parameters to percentage values, i.e. width="50%" height="50%", the SWF will not render in the bowser window. You can only use absolute pixel values, i.e. width="320" height="240". This happens with standard (Flash 6) embed code and with SWFObject 2.0.

The workaround is to use SWFObject 1.5. For some reason this renders percentage values without any problems in every browser I've tested (I haven't tried it with Opera though). SWFObject 1.5 is at: http://blog.deconcept.com/swfobject/

and from swfobject:

SWFObject detects Flash player versions in these browsers from version 3 and up, and will allow users to interact with your Flash content without ‘activating’ it first.

This I became aware of while testing audio 6.x since the player didn't even show from sf.net in Opera. So I guess this is no miricle any more :)

As I don't know much about audio so far bare with me. But I think I read somewhere around here someone asking why the player needs to be clicked twice before it starts. So if it is not allready this maybe could be integrated into audio. It's MIT licenced.

No harm ment,
CU

Oh, I nearly forgot, here is something else that might come in handy for audio. Here is a small wrapp-up:

A Flash-based MP3 music player with an autoresume feature! I've added this feature to the popular, free XSPF Music Player software.
This player stores the player's current track and playback position in a Flash cookie. When the user moves between pages, the player goes away, of course. But the player on the new page will see the cookie and pick up where the first player left off.
(...)
My autoresume code respects the stop button.
(...)
2006-12-29: shuffle and autoplay are fully compatible with autoresume. Volume control settings are remembered by autoresume. General bug fixes.
(...)
Lacy Morrow created an enhanced version with shuffle capabilities. My own version is based on Lacy Morrow's and adds the autoresume option.

Cheers

Interestingly enough, I can see the player fine in Firefox and Safari, but in IE 7 it's just a white box.

Update: I know have successfully imported two albums on another site (not local, no .htaccess allowed, i.e. no clean urls, upload_max_filesize and post_max_size set to 50MB if that matters at all) after I first ran into the situation that the importer messed up tags/albums. After I deleted those and uploaded new files with no blank spaces in their file names I worked fine (I don't know if that's the problem, though). I also see und can use 1pixelOut but there is know options to select players, either. The only thing not working at all I noticed was the playlist module. It does install allright but after deploying the link add to playlist the following error occurs:

warning: array_fill() [function.array-fill]: Number of elements must be positive in /path/to/drupal/includes/database.inc on line 235.
warning: implode() [function.implode]: Bad arguments. in /path/to/drupal/includes/database.inc on line 235.
warning: array_keys() [function.array-keys]: The first argument should be an array in /path/to/drupal/modules/user/user.module on line 500.
user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 1 query: SELECT p.perm FROM drupal_nptest_role r INNER JOIN drupal_nptest_permission p ON p.rid = r.rid WHERE r.rid IN () in /path/to/drupal/modules/user/user.module on line 500.

Edit: I noticed two more things:

1. Only in Opera (9.50) on my standart installation on the same server with garland I have to click 1PixelOut twice to start playback. On my "self-made" subtheme of zen it starts right away on the first click (tested with FF 3 and IE 7 also).
2. Autopath generates funny aliases with a posfix
   

   %00

   on most(!) titles and album names resulting in 404 error when calling that path. Tags on the files where generated using Windows foobar2000 (a high-quality player if your not familiar) so a render it more likely to have something to do with Windows line-breaks? Just guessing. When editing nodes tag fields on such a node I get this:

   The following errors were encountered, preventing the ID3 tags from being saved:
   - ID3v2 APIC data is not properly structured
   - FormatDataForID3v2() failed
   

/Edit

I'm considering installing another test installation in D5 to see what should be possible (in the long run). Or is there a more detailed description I haven't gotten my hands on, yet, besides the handbook part? I'm interested in a more gallery like (image module) display of by/album/albumname to show the albums image(s) only once and list the tracks rather li-style, i.e. so it's more like one node rather than a list of nodes. I'm I on the right track to assume this needs views? Any hints appreciated!

Cheers.

Hi

When will the new drupal 6.2 audio module be available?

re: When will the new drupal 6.2 audio module be available?

see #48 from May 30, 2008

be very careful with it, it's pretty broken.

which I can confirm, so I assume it will take a few weeks, still. Correct me, if I'm underestimating, drewish.

Thanks thomas

Small update:

In the meantime I could get my hands on audio.module in more detail and just did a fresh install (meaning deleting the audio folder and replacing it with a fresh version downloaded here plus version 1.7.8b2 of getid3 going through your nice README.txt in detail).

The issue I experienced before (see #55 above) when poof. When I now edit some audio node and save it that before pathauto send to /album/day-in-june%00/lazy%00 now is homed correctly at and links are fine.

The only error persisting is the one about APIC data not properly structured (bug reported as #265493: Getid3 error.

Cheers.

Small update:

In the meantime I could get my hands on audio.module in more detail and just did a fresh directory install meaning deleting the audio folder and replacing it with a fresh 6.x-1.x-dev plus version 1.7.8b2 of getid3 going through that nice README.txt included in detail.

The issue I experienced before (see #55 above) went poof. When I now edit some audio node that pathauto send to /album/day-in-june%00/lazy%00 before now is homed correctly at /album/day-in-june/lazy after submitting the node edit form. A pitty there is no shortcut in admin/content/node as the image.module's on to "rebuild image thumbnails", something like "reread all audio meta tags". But for me that's fine, and to be honest: When does one really need that? Lucky me the band I'm building the site for hasn't been around for decades ;) I just deleted all audio nodes and reimported them which led to no errors and links are fine. Hurray! Just be warned if someone followes my descriptions that audio files are deleted, too. No errors, though, if you move them manually before actually deleting the node in drupal.

The only error persisting is the one about APIC data not properly structured (bug reported as #265493: Getid3 error).

Cheers and thanks once more for your effort!

subscribe

did a little more work last night. the audio module now depends on the getid3 module.

So does anyone actually have this module working with 6.2? For me, on a fresh install with no other additional modules except audio, token, and views, when I try to create an audio node, and I browse to an mp3 and click submit or preview, the file doesnt get attached and error messages show up complaining about NULL filenames.. Any else see this?

On my site I used autdio's importer which worked fine for me (see above). I have two albums worth of audio nodes and playback works fine with them. Although I haven't done any individual stuff yet like creating "album views" so it's just plain out-of-the-box. Except one block where I tried to include a button player which does show but not play. But maybe it's just not configured right; I haven't worked on it lately.

Oh and theming the player does not work either as described for template.php in the dokumentation. But again, it might also be me.

Cheers.

Btw. Is there any more documentation that I might have missed that the one pointed out from the module's main page?

Drewish,

Any news on the status of this, and when it could be production site ready? I know you're probably pretty busy, but I'm waiting on this thing to launch my site.

Thanks.

sorry i don't, i was hoping that some of the people who did the initial porting would have some time work on it.

Hi folks, I couldn't find this mentioned anywhere in the issues or in this thread, so I figured I'd mention it. If you'd prefer I start another issue let me know.

This is the 6.x dev version of the module, running on Drupal 6.2, that is currently up on the module page (to be precise 6.x-1.x-dev dated from June 19th).

I get this PHP error when I enable "Attach audio files" in the workflow settings for the Story content type (I'm going to assume this would be the same with any content type):

PHP Fatal error: Call to undefined function audio_prepare() in /var/www/htdocs/sites/all/modules/audio/contrib/attach/audio_attach.module on line 153, referer: http://somesite.com/node/add/blog

Function got renamed?

Anyways, hope this helps...if I have time to dig further and offer a patch I will do so...otherwise thanks for all the work done on this!

Best,
Dave

I am also interested in the porting of this module to drupal 6. I'm no programmer, but in the interest of using the module on an upcoming site, I would be happy to assist in some way so that we can get a stable release for the module.

This module works beautifully in Drupal 5 with the first version of views (I downgraded my site from Drupal 6 to 5 for the time being). It's definitely worth it to have the views integration working before anyone uses this with Drupal 6.

Subscribing

subscribe

subscribe

Fix menus for 6.2 and more: just add marked lines... no time to make patch
Next is something wrong with playlist...

  $items['admin/settings/audio/metadata'] = array(
    'title' => 'Metadata tags',
    'page callback' => 'drupal_get_form',
    'page arguments' => array('audio_admin_settings_metadata'),
    'access arguments' => array('administer audio'), //add this
    'file' => 'audio.admin.inc', //add this
    'type' => MENU_LOCAL_TASK,
  );
  $items['admin/settings/audio/players'] = array(
    'title' => 'Players',
    'page callback' => 'drupal_get_form',
    'page arguments' => array('audio_admin_settings_players'),
    'access arguments' => array('administer audio'), //add this
    'file' => 'audio.admin.inc', //add this
    'type' => MENU_LOCAL_TASK,
  );

i'm guessing that the playlists are totally screwed up... but yeah roll a patch for that and i'll commit it asap

Does anyone have this module working on 6.3 yet? i'm battling, and client would really love this module, they are wanting to podcast audio, so this module's going to be a huge part of that.

Which one should i be using - the one on this page, or the 19 June 08 one on the Module's home page?

thanks,

subscribe

tracking

This is so exciting! It looks like this module isn't stuck in open source limbo any more!

Subscribe

I wasn't looking closely at the dates. I guess this module is stuck in open source limbo. Why isn't this module a priority?

@acochran, regardless of what you had to say, this issue is about porting the audio.module to drupal 6.x, so have updated the title again to reflect this fact.

thanks.

We have been waiting for more than six months for this module to be ready for D6. We are now giving up hope, sorry. Does anyone know if it is possible to downgrade from D6.4 to D5?

yes, unfortunately, this module is taking too long to be ported. But since I am not a coder, I can't be demanding. I know.

however, and to answer smoltron's question, it all depends on your specific case and what you want to achieve with the module. but, Views + CCK can very well have a valid alternative.

here's a patch for the menu items

thanks aaron, committed that to HEAD.

subscribe

But anyone know of a really basic Audio player to play about a dozen tracks for a bands site running Drual 6.x?

Second KaityUK.
I'm going to try out the dev release regardless of any issues, but am eagerly awaiting a beta.

@KaityUK:

I have the Audio module latest release of 6.x-1.x-dev (2008-Sep-07) working on 6.x at http://amplifires.co.uk/

Haven't tried audio attach, but so far so good...

Pete

closing this since there's plenty of bug specific issues.

same Error here.

There are many duplicate nodes related this...

http://drupal.org/node/311284
http://drupal.org/node/272926
http://drupal.org/node/299037
http://drupal.org/node/294317

Call to undefined function audio_prepare() in /sites/all/modules/audio/contrib/attach/audio_attach.module on line 153

any Luck?

4vinoth, this was closed for a reason. use the related issues.