Bookreview module submission guidelines repeats

This affects other node modules too. It appears to be a bug in Drupal core. I'm re-assigning this issue to the help.module, where I suspect the problem is.

This bug has nothing to do with help.module, so I changed that.

This is due, actually, to a redundancy in book review module (it might be also in some others. I have not checked that) within its implementation of the hook_help function, bookreview_help:

    case 'node/add/bookreview':
      $output = variable_get('bookreview_help', '');
      break;

node.module (core module) already handles this in its own implementation of hook_help, node_help:

  if (arg(0) == 'node' && arg(1) == 'add' && $type = arg(2)) {
    return variable_get($type .'_help', '');
  }

I include a patch ready to commit that fixes this with bookreview.module.

Moral: if you write a newmodule that creates a new type of node, don't add the

    case 'node/add/newnodetype':
      $output = variable_get('newnodetype_help', '');
      break;

It might be useful to add a note about this in the hook_help API reference page at drupaldocs.org

Committed to DRUPAL-4-6 and HEAD.