admin/foo URLs should be consistent

morphir - January 22, 2008 - 15:04
Project:Drupal
Version:7.x-dev
Component:system.module
Category:bug report
Priority:normal
Assigned:morphir
Status:duplicate
Issue tags:Usability
Description

admin/user should be admin/users in my opinion.

This is because you administer users and not a user per definition. It's also a little confusing, because user/1 will take you to that very user. And admin/user will currently take you to the page where all user specific things are configured.

I'm filing this a a minor bug, as I consider this a usability bug =)

#1

Gábor Hojtsy - January 22, 2008 - 15:07
Version:6.x-dev» 7.x-dev

We are not changing paths unless critical in D6. These urls were named after modules initially. So there comes /admin/content/node and not /admin/content/node*s* and the like.

#2

morphir - January 22, 2008 - 15:35

"/admin/content/node and not /admin/content/node*s* and the like."

I can agree with setting this as a 7-branch issue. However, this thread should focus on renaming the different paths to a more logic manner for end users, not according to the module name. Thanks for clarifying gabor.

#3

Rob Loach - January 25, 2008 - 07:15

In my opinion, admin/user nicely refers to "Administration >> User Management". admin/user/user, however, could be changed to admin/user/users, as you're in "Administration >> User Management >> Users".

#4

morphir - January 25, 2008 - 20:27

sure, it's better than what we have today. But I still stand by that we should rename it to admin/users/users.

Because admin/users will deal with common rules/roles etc. against users :

* Access rules
* Permissions
* Roles
* User settings
* Users

This means you deal with all this things towards users and not a specific user.

#5

morphir - January 25, 2008 - 21:26
Component:path.module» user.module

this patch applies against several modules - so path.module as the issue specifications says is simply wrong. Biggest changes are made against user.module.

with this patch the path admin/user and admin/user/user will become admin/users and admin/users/users

AttachmentSizeStatusTest resultOperations
admin_user_path.patch42.6 KBIgnoredNoneNone

#6

morphir - January 25, 2008 - 21:27
Status:active» needs review

*changed status*

#7

morphir - January 30, 2008 - 06:14

fixed typo. I'm currently using this patch, and all seems to work.

AttachmentSizeStatusTest resultOperations
user_path.patch42.59 KBIgnoredNoneNone

#8

morphir - February 6, 2008 - 16:55
Priority:minor» critical

Since this is really is just a minor change but has great impact to usability I'm marking this a critical. (we need more critical eyes on this certain issues as well..)

#9

Dries - February 6, 2008 - 19:45
Priority:critical» normal

I think this is a good change, but shouldn't we try to be consistent with this? Afaik, everything is singular right now...

#10

catch - July 25, 2008 - 11:48
Status:needs review» needs work

I reckon this would be good just with admin/user/users - would go with admin/user/roles for example. I'm not so sure about changing admin/user to admin/users. Either way, there's definitely inconsistencies with some of these paths, so bump.

#11

dmitrig01 - July 26, 2008 - 07:06

admin/setting*s*
admin/user
admin/content
admin/build

#12

catch - July 26, 2008 - 08:18
Title:admin/user should be admin/users» admin/foo URLs should be consistent

Since admin/settings is now called "site configuration", we could probably change it to admin/configuration?

#13

Arancaytar - July 26, 2008 - 08:47

If at all, I vote for "config". Don't make those URLs even longer than they already are.

#14

webchick - July 27, 2008 - 23:10
Component:user.module» usability

admin/build/block -> admin/build/blocks. That one gets me every time.

Promoting this to a "usability" bug.

#15

Arancaytar - July 27, 2008 - 23:37

admin/build/block -> admin/build/blocks

Welcome to the club... I've aliased it by now just out of annoyance. :)

#16

tstoeckler - January 12, 2009 - 21:49
Component:usability» path.module

What's the status of this issue? Maybe someone with knowledge about the core patch-naming could give an update.
On a related note, two paths that use plurals as of now:
/admin/build/modules and
/admin/build/themes

/admin/build/blocks really seems "consistent"

I had to change the "Component" tag, because there is no Usability component any more (or I am stupid/have turned blind), so I am setting this to path.module, because, well, it has to do with paths. Could be system.module just as well, though, I really don't know.

#17

catch - January 13, 2009 - 10:46
Component:path.module» system.module

tstoeckler - I think it just needs the patch updating, most people seem to agree we need to standardise the URLs.

This is a tricky one to categorise, but since system.module provides most of the admin paths I'm moving it there - you can now tag issues with 'usability', which in nearly every case but this one is a better system for keeping track of these.

#18

tstoeckler - January 14, 2009 - 18:54

in an effort to keep this issue alive: I will try to attach an updated patch on the weekend, but as I have very (!!!) little coding knowledge someone would have to look over it then (with more attention than would usually be needed for such a minor patch, I suppose).
Just putting that out there.

#19

catch - January 14, 2009 - 21:46

tstoeckler, that'd be great. If you need any help with either code or rolling patches, you can always drop in to #drupal on irc and there's plenty of people willing to help.

#20

tstoeckler - January 20, 2009 - 18:39

well, the weekend is over and still no patch...
this is still on my mind though, working it's way to the top of my TO-DO list.
One thing to speed this up: Since I'm running Windows, I have quite some problems with command line operations. To actually know where to go I would like to know all the occurences of admin patchs in Drupal, so if someone could just
grep -r admin/ > foo.txt or something like that and attach it to this post, that would save me going through all the files manually....
In any case, I'll try to provide a patch soon!

#21

tstoeckler - January 21, 2009 - 00:38

Now I guess this can be considered exaggerated, but I created a Google Spreadsheet with all the current admin links and what I think they should be, to finally make all admin links consistent. Comments and discussion wanted:
http://spreadsheets.google.com/ccc?key=p_hEOQXyl5m2cy_mYPvkVYQ

Quick summary of what I will change in the patch (coming soon!):
admin/build/modules
admin/build/themes
admin/user/permissions
admin/user/roles
each to the singular version.

#22

tstoeckler - January 22, 2009 - 00:41

Here I go, this is a straight search/replace of current HEAD. Hope testbot likes it... (works perfectly on my machine, though)

AttachmentSizeStatusTest resultOperations
admin_links.patch58.37 KBIdleFailed: Failed to apply patch.View details | Re-test

#23

tstoeckler - January 22, 2009 - 00:41
Status:needs work» needs review

Forgot to change status...

#24

tstoeckler - January 22, 2009 - 13:11

I guess I need to reattach for the testbot to notice!?

AttachmentSizeStatusTest resultOperations
admin_links.patch58.37 KBIdleFailed: Failed to apply patch.View details | Re-test

#25

System Message - January 22, 2009 - 14:05
Status:needs review» needs work

The last submitted patch failed testing.

#26

tstoeckler - January 22, 2009 - 14:52
Status:needs work» needs review

I seem to be having some problems with the patch rolling, I get this from time to time with TortoiseCVS. Could someone reroll or else tell me what is wrong so I can adapt the patch?! Thanks...

#27

tstoeckler - January 25, 2009 - 14:34

Something I just noticed:
The current patch uses for instance:

<a href="@permissions">permissions page</a> ... '@permissions' => url('admin/user/permission')))

Would it be better coding style to use <a href="@permission">???

#28

mr.baileys - February 24, 2009 - 07:13

Marked #99091: Admin URLs not consistent as a duplicate of this one.

#29

tstoeckler - March 17, 2009 - 00:18

in an attempt to bump this one.

New patch attached, which ONLY changes

admin/build/modules -> admin/build/module
and
admin/build/themes -> admin/build/theme

which was consensus during this whole discussion.

AttachmentSizeStatusTest resultOperations
consistent-paths.patch35.56 KBIdleFailed: Failed to run tests.View details | Re-test

#30

System Message - March 17, 2009 - 00:25
Status:needs review» needs work

The last submitted patch failed testing.

#31

Rob Loach - March 17, 2009 - 01:27

Sorry for being a bit late on chiming in here, but why are we going singular? Webchick @ #14 asked to go plural....

I've made an update in the Google Document Administration Links outlining the plural changes we'd have to make. If anyone notices anything else, please be bold.

#32

tstoeckler - March 17, 2009 - 01:54

I was pretty bold I guess.
The document is now much easier to read...

It really boils down to SINGULAR vs. PLURAL, which could end in an endless bikeshed.
To my mind, for instance, the shorter a path is, the better.
Since I guess (from the fact how long this issue has lingered around) no one is really one the fence about this one, I guess it would be best if webchick and/or Dries hopped in to say which one they are going to commit and then someone can do the dirty work.

#33

Chris Johnson - March 17, 2009 - 19:25

And now for a differing view: I don't see how URLs are much of a usability issue. Only geeks like us really look at URLs and try to make sense of them. Most users do not look at them, do not understand them and really shouldn't even ever need to seem. They should be opaque resource handles to some location or a resource, and nothing more.

So, based on that, we might as well improve the developer experience (DX) by making URLs be consistent with their modules, or something else developers will benefit from.

/me crawls back into hole. :-)

#34

webchick - March 17, 2009 - 19:28

Hm.

In Drupal 7, we've been standardizing on single for all of our table names in core. Basically because it's always consistent and doesn't get us into weird English pluralization rules (goose vs. geese, sheep vs. sheep... apparently I forsee a big boom in animal named modules in the future :P) which makes it easier for non-native speakers to spot a word they've already seen before. Furthermore, it also makes it possible to do some neat ORM-style things like drupal_save('object_name') and everything just figures itself out.

However, all of that stuff is developer-facing.

For user facing things, I think it's more important to go with what is natural to them. And what is natural to them is if you click on a link that says "Administer blocks", the URL that that corresponds to is admin/.../blocks. I'm not crazy about the idea of renaming all of our pages to "Administer Block" because that is extremely awkward and dumb, so +1 on plural URLs.

Or, more accurately, +1 on URLs that match the page title.

#35

tstoeckler - March 17, 2009 - 21:47

Changed the spreadsheet as per #34 and marked the URLs that need to be patched bold, although with some URLs it is debatable, whether parts of the link title should be omitted, so it might actually be worthwhile to take a glance and drop a comment here or there.
I personally have no time to roll a new patch in the next few days, so anyone?!

#36

Rob Loach - March 21, 2009 - 06:48
Status:needs work» needs review

This patch makes the following changes, as suggested in #35....

Should we split this up into a bunch of different issues so that it's not a >200K patch? Kittens are nice, you know.

AttachmentSizeStatusTest resultOperations
plural.patch237.48 KBIdlePassed: 10561 passes, 0 fails, 0 exceptionsView details | Re-test

#37

tstoeckler - March 21, 2009 - 18:43

Personally I think, since this is really just find & replace, it's rather easy to review (I just started on the first part), and since there's no real code change, so all tests passing really says enough on it's own, IMO. Just my two cents, though.

#38

sun - March 23, 2009 - 03:07
Status:needs review» duplicate

Many parts of this patch are duplicate of #408160: Normal users should not see the create content link appear by default in a menu called "Management".

Also, admin paths should always use the module name. We recently changed a few paths (e.g. admin/settings/filters => filter) that didn't equal the module name.

#39

mr.baileys - March 23, 2009 - 08:03

@sun:

Also, admin paths should always use the module name.

IMHO, this issue is challenging the very notion that paths should always use the module name, see for example webchick's comment #34: "Or, more accurately, +1 on URLs that match the page title."

I'm not entirely sure that this should be marked as a duplicate.

#40

sun - March 23, 2009 - 14:11

Match the page title? Seriously?

So in Drupal 8 the usability team decides that "users" should be called "members" now, because 99% of all web sites call it "members".

So we will rename all of our internal paths?

Also, which page title do you mean? The English, the French, or the German?

I somehow must have missed the patch that translates internal paths.

#41

mr.baileys - March 23, 2009 - 14:44

So in Drupal 8 the usability team decides that "users" should be called "members" now, because 99% of all web sites call it "members".

So we will rename all of our internal paths?

Well... yes (please excuse my ignorance, I'm still wet behind the ears when it comes to core).

As someone new to Drupal, I felt this issue raised some valid points: why is it admin/build/modules but admin/build/block (I'm going to manage my blocks, not just one). You call these internal paths, but I frequently hack the url to get to these pages because I don't want to click my way around, or because I'm lazy. When the usability team decides to rename users, I'd prefer the paths to be updated too. Having to go to admin/user to manage your members just seems unintuitive to me.

Maybe I should not have lifted the "Match the page title" quote out of webchick's comment (since the comment itself is a lot more verbose), but I'm not sure having the URL match the module name is the best way to go either.

I somehow must have missed the patch that translates internal paths.

Mmm, do I detect some sarcasm here? I did not mean to offend or annoy you, and I might not be aware of the history behind why things are/work they way they do. I just wondered if this issue should be marked duplicate just yet, as the entire point of this issue is to discuss whether or not it makes sense to change some of the URLs. (see the comment early on: "this thread should focus on renaming the different paths to a more logic manner for end users")

So if this does get discarded, marking it "won't fix" might make more sense... Anyway, that's just my opinion. I realize I might be out of my league here, so I'll go back to lurk-mode...

 
 

Drupal is a registered trademark of Dries Buytaert.