extra line breaks in theme_cck_address
ashtonium - January 22, 2008 - 20:52
| Project: | Address field for CCK |
| Version: | 5.x-2.1 |
| Component: | Code |
| Category: | feature request |
| Priority: | minor |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
I noticed that there was always at least one blank line of text after the displayed address, and found that at the end of theme_cck_address there are two extra HTML line breaks added on: (line number 1230 in cck_address.module v5.x-2.1)
$output .= '<br /><br />';I know it's easy to override that theme function and remove the line, but I can't figure out why it's even there to begin with. If it was for spacing, then that should be done by the CSS, not by empty lines of text. Hard-coding in empty lines like that isn't very themer friendly, so I'm suggesting that the line be removed.
thanks, -ashtonium
#1
It seems like there was a good reason at the time, but I don't recall what. It may be that I was experimenting and left it in. More specifically, I recall experimenting with allowing 'multiple' addresses like some other cck fields allow multiple values. It turned out to be very impractical and would have more than doubled the code.
However, I would not call this a bug (since it can be overridden and does not impair the operation of the module at all), but a feature request that I'm happy to add to the pile. So unless I can come up with a very good reason to keep it, I'll remove it from the next release.
#2
Sounds good; thanks for the consideration.
#3
fixed