Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.I noticed that there was always at least one blank line of text after the displayed address, and found that at the end of theme_cck_address there are two extra HTML line breaks added on: (line number 1230 in cck_address.module v5.x-2.1)
$output .= '<br /><br />';
I know it's easy to override that theme function and remove the line, but I can't figure out why it's even there to begin with. If it was for spacing, then that should be done by the CSS, not by empty lines of text. Hard-coding in empty lines like that isn't very themer friendly, so I'm suggesting that the line be removed.
thanks, -ashtonium
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | Addition of line break error.jpg | 46.42 KB | jmangion |
Comments
Comment #1
rconstantine commentedIt seems like there was a good reason at the time, but I don't recall what. It may be that I was experimenting and left it in. More specifically, I recall experimenting with allowing 'multiple' addresses like some other cck fields allow multiple values. It turned out to be very impractical and would have more than doubled the code.
However, I would not call this a bug (since it can be overridden and does not impair the operation of the module at all), but a feature request that I'm happy to add to the pile. So unless I can come up with a very good reason to keep it, I'll remove it from the next release.
Comment #2
ashtonium commentedSounds good; thanks for the consideration.
Comment #3
NewZeal commentedfixed
Comment #4
jmangion commentedThe addition of "
" to the Zen theme is wreaking havoc on my site's design. For some reason, it has inserted itself 11 times when the page is displayed, and I don't yet know how to override this "feature". So, now my header (where this block was/is to be displayed) now takes up most of my page, making the site look ridiculous.
I'm attaching a picture of the resulting code that shows up when the page is displayed.
Please help me figure out how to remove those line breaks.
Thanks!
Comment #5
dwwWhat does this have to do with the Project module?
Comment #6
echoz commentedThis looks like code from some very poor wysiwyg setup, not produced by Zen.