Currently, bullets are removed from the admin filter ul list with list-style-type: none. However, if you have used list-style-image to style ul bullets in your site, then the bullets will still show up because list-style-type does not override list-style-image. The easiest way to fix this is to change list-style-type to list-style in #node-admin-filter in node.css. The list-style property sets all the properties for a list in one declaration. In contrast, the list-style-type sets the type of list-item marker (ex. disc, circle, square, etc.).
I have made this css change on a few sites and thought that it might be a good modification to core. I've attached my very small patch.
Here's the old code:
#node-admin-filter ul {
list-style-type: none;
padding: 0;
margin: 0;
width: 100%;
}
And, here's the revised code:
#node-admin-filter ul {
list-style: none;
padding: 0;
margin: 0;
width: 100%;
}
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | Picture 2.png | 11.04 KB | dvessel |
| #7 | Picture 1.png | 7.69 KB | dvessel |
| #1 | css-list.patch | 2.17 KB | pancho |
| node_css_list.patch | 247 bytes | JuliaKM |
Comments
Comment #1
panchoGood catch! The change makes sense!
I rerolled the patch changing this also in other occurences.
Please test...
Comment #2
JuliaKM commentedThanks! I applied the patch and it worked perfectly.
Comment #3
jody lynnPlease take a look at http://drupal.org/node/197833 . When I looked into this issue it seemed to me that it's really because theme_node_filter_form is no longer being called. While your patch treats the symptom I'm concerned that the real cause is more complicated.
Comment #4
jody lynnThis is being taken care of at http://drupal.org/node/197833
Comment #5
JuliaKM commentedI'm not sure if http://drupal.org/node/197833 solves the issue. All that I am trying to do here is get the style to remove bullets changed from list-style-type: none; to list-style:none so that if you add images within a site using list-style-image, they are removed with list-style:none. If list-style-type:none stays, then list-style-type:none will not override images.
As far as I can tell, http://drupal.org/node/197833 adds back in the id #node-admin-filter but it does not change the css from list-style-type:none to list-style:none.
Comment #6
panchoAccording to JuliaKM, this is not fixed by #197833, so it's no duplicate. This needs to be checked.
Comment #7
dvessel commentedYou're forgetting IE. Both 6 & 7 do not read list items the same way. There's a workaround but I don't think it's worth it. When using images for your list items, override it from your theme.
Comment #8
dvessel commentedwrong screen shot.
Comment #9
JuliaKM commentedOk. Will do. Thanks for your help.