Hello,
I am trying out the MiniPanel wherein I am creating (as an example) 2 flexible minipanels within a Panel with rounded corners.
Evreything works well without a problem when I have one MiniPanel withing a Panel or a Panel without minipanels.But the problem happens when I try to add the second Minipanel.The content looks good but the second one looses its rounded corners.Happens with any number of new mini panels added.
The module is simply great ( one of the best in drupal) and hope this is fixed .
P.S: I am new to drupal and may have missed some key info to make it a complete 'Issue Ticket' .Please indicate if you need furthur information or if you would want any 'testing' help for this incredible module
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | panels-add-rounded-corners-css-fix.patch | 380 bytes | dellintosh |
Comments
Comment #1
snelson commentedI ran into this same issue ...
In rounded_corners.inc, panels_add_rounded_corners_css(), we have:
Basically, this prevents the rounded corners CSS from being added twice. The problem is $display->name is always null, so the CSS is only added once. Not sure if $display->name not supposed to exist, but its briefly mentioned here: http://drupal.org/node/215874.
Note: the project I'm working on is an upgrade from Panels 1.x, so that could have something to do with it as well.
The fix is really easy, I changed the above function to use $display->css_id instead of $display->name:
Changing the module code itself is not good though, so hopefully the fix can get into the release.
Cheers,
Scott
Comment #2
dellintosh commentedApplied patch, tested, works! :)
Later,
dellintosh
(Also attaching patch file here to simplify implementation into codebase.)
Comment #3
sdboyer commentedHeh, wow...$display->name. That's a blast from the past. Good catch there, snelson, and thanks for the review dellintosh. In future, though, if it'd be possible for you to do a unified diff against CVS, that's the most preferable option.
Committed.
Comment #4
sdboyer commentedComment #5
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.