Hi

I can't see all poll results, I can see 10 results (tab "results" on poll node), and if i change sorting from top to bottom, I can see other 10 results (from bottom), not more.
So when my poll has 50 voters, I can't see 30 of them.
I suppose to show all poll results with paging.

thanks
Igorik
http://www.somvprahe.sk

CommentFileSizeAuthor
#6 advpoll_824496_7_pager.patch3.13 KBmiro_dietiker
#3 advpoll-215675.patch1.27 KBjrglasgow

Comments

igorik’s picture

igorik commented
Category: feature » bug

Hi
I redeclare this feature request as a bug.
On page with votes for some poll is written: This table lists all the recorded votes for this poll...

But sql query in advpoll.module has only 20 results and no paging.

$result = pager_query("SELECT v.uid, v.hostname, v.timestamp, u.name FROM {votingapi_vote} v LEFT JOIN {users} u ON v.uid = u.uid WHERE v.content_type = 'advpoll' AND v.content_id = %d GROUP BY v.uid, v.hostname, v.timestamp". tablesort_sql($header), 20, 0, NULL, $node->nid);

So probably there is needed to add input into admin poll setting how many results he want on page and change it in query into that variable, and add paging into this page. (or just to add paging into this page)

Thanks
Igorik
http://www.somvprahe.sk

maartenvg’s picture

maartenvg commented

As far as I can see you can remove the GROUP BY statement. It interferes with the pager, which causes it to be hidden, and it doesn't serve a goal.

jrglasgow’s picture

jrglasgow commented
Status: Active » Needs review
StatusFileSize
new advpoll-215675.patch1.27 KB

I found this problem as well. Here is a patch that will solve the issue, at least it solved it for me.

the pager_query() function takes a count query as an option. It says in the documentation that

Unfortunately, the rewrite rule does not always work as intended for queries that already have a "COUNT(*)" or a "GROUP BY" clause, and possibly for other complex queries. In those cases, you can optionally pass a query that will be used to count the records.

I have customized the count query to return the count.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented

sounds reasonable to introduce a separate pager query then.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Version: 5.x-1.x-dev » 6.x-1.x-dev

We should first check and correct the current version for this issue.
Is this still present in 6--1?

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Title: cannot see all results » cannot see all results, add pager query
StatusFileSize
new advpoll_824496_7_pager.patch3.13 KB

Updating the patch to represent current codebase. This might be committed as intermediate solution.

Note that the whole advpoll_votes_page() should be reworked completely. Current code is very ugly and not reliable.

See some related documents:
http://drupal.org/node/142144
http://nanwich.info/DBPager.htm
http://api.drupal.org/api/function/pager_query

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Title: cannot see all results, add pager query » overhaul votes page code, cannot see all results, add pager query
Status: Needs review » Needs work

Committed to have the working pager for the moment.
(Changed codestyle of SQL to have structural representation of the statements..)
Switching to needs work to force the need to overhaul the results queries in total.

gobinathm’s picture

gobinathm
he/him
Primary language English
Location Milton, Ontario
commented
Issue summary: View changes
Status: Needs work » Closed (outdated)

D6 is EOL hence this issue won't be fixed (or) attended. So closing it.