overhaul votes page code, cannot see all results, add pager query

Hi
I redeclare this feature request as a bug.
On page with votes for some poll is written: This table lists all the recorded votes for this poll...

But sql query in advpoll.module has only 20 results and no paging.

$result = pager_query("SELECT v.uid, v.hostname, v.timestamp, u.name FROM {votingapi_vote} v LEFT JOIN {users} u ON v.uid = u.uid WHERE v.content_type = 'advpoll' AND v.content_id = %d GROUP BY v.uid, v.hostname, v.timestamp". tablesort_sql($header), 20, 0, NULL, $node->nid);

So probably there is needed to add input into admin poll setting how many results he want on page and change it in query into that variable, and add paging into this page. (or just to add paging into this page)

Thanks
Igorik
http://www.somvprahe.sk

I found this problem as well. Here is a patch that will solve the issue, at least it solved it for me.

the pager_query() function takes a count query as an option. It says in the documentation that

Unfortunately, the rewrite rule does not always work as intended for queries that already have a "COUNT(*)" or a "GROUP BY" clause, and possibly for other complex queries. In those cases, you can optionally pass a query that will be used to count the records.

I have customized the count query to return the count.

We should first check and correct the current version for this issue.
Is this still present in 6--1?

Committed to have the working pager for the moment.
(Changed codestyle of SQL to have structural representation of the statements..)
Switching to needs work to force the need to overhaul the results queries in total.