I'm working on splitting the location table into {location} and {location_instance}. This will allow fixing all the issues in the title and more.

This issue is a meta-issue to mark issues that this work will fix as duplicates against.

Comments

bdragon’s picture

bdragon commented

http://drupal.org/node/136601:
location disappears from node display when node version (revision) is rolled back.

I had noticed this issue earlier, it will be part of the fixes.

bdragon’s picture

bdragon commented

http://drupal.org/node/41088:
Multiple locations per node.

Although location currently has support for multiple locations at the moment, they aren't reusable. After I split the location table, it will be possible to reuse locations.

bdragon’s picture

bdragon commented
Title: [master][meta] Normalize location table / enable shared locations / fix location deletion / fix revisions » [master][meta] Normalize location table / enable shared locations / fix location deletion / fix revisions / make forms not suck

Adding "make forms not suck" because internally that's rolled into my patch as well.

Additionally, I'm *almost* ready to post the first version of the actual patch to get some feedback on.

catch’s picture

catch
he/him
Primary language English
commented

Optional lat/long/country fields on node form which already had some other dups marked against it: http://drupal.org/node/59081 (and this one: http://drupal.org/node/39486)
location selector widget: http://drupal.org/node/93655
Shared locations - lots of information there but now dup of this: http://drupal.org/node/111574

scottrigby’s picture

scottrigby
he/him
Primary language English
Location Brooklyn, NY
commented

Thanks Catch for wrangling these together... Thanks BDragon for kicking ass with this module...
I'll help test and feedback in any way I can.
Just a note: there are some specific (but important!) issues wrapped up in each of these links, which are not exact duplicates.
Looking forward to this!
:)
Scott

catch’s picture

catch
he/him
Primary language English
commented

Just to note, I may well have been a bit over-zealous with marking things as duplicate, so if you think something is important and might get buried, please re-open it.

bdragon’s picture

bdragon commented

Nah, this is the master issue for anything regarding fapi-ization of location, so there's a LOT of stuff that's in scope.

csc4’s picture

csc4 commented

Subscribing - and will try to help out testing when the patch stage is reached

ardas’s picture

ardas commented

I think that to improve location module significantly we need to think about utilizing CCK as much as possible and remove many features from location module. Location module tries to implement its own fields, with UI settings, multiple feature - this is a huge piece of work and I think there is no sense to continue this way. Location module has to only 'request' CCK to create necessary fields. That should become possible in 6.0

bdragon’s picture

bdragon commented

The current version of my patch has been committed to HEAD so we can all collaborate on development in the code sprint on Friday.

Mark Theunissen’s picture

Mark Theunissen commented

subscribing - thanks everyone

bcn’s picture

bcn commented

tracking...

dww’s picture

dww
we/he/they
commented

Not entirely sure why, but catch marked #45593: adding support for a default province/state? duplicate with this. So, if you're really doing a monster patch in here to change everything, please include support for specifying a default state (and I guess #214894: Force a default CITY selection too). Honestly, #45593 seems more closely related to a monster patch for #31609: Start at a better country/province interface, but I could be wrong... ;)

summit’s picture

summit commented

Hi, Very interested about this! Subscribing, Martijn

beatnikdude’s picture

beatnikdude commented

subscribing

socialnicheguru’s picture

socialnicheguru commented

subscribing.

when I first started. I created a node profile for a venue and used cck fields. I later learned that CCK and location do not work well together. I wanted to use the address information for proximity filters and mapping operations. Bummer unless someone knows away.

I would simply like a user to be able to goto an event use autoselect to write in a venue they might want to attend and have the venue node populate the location table for the event content type. This might just be a stepping stone to the greater uber vision described above.

Chris

bdragon’s picture

bdragon commented
Status: Active » Fixed

We've come a long way.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

socialnicheguru’s picture

socialnicheguru commented

did you get my comment in #16 to work?

goron’s picture

goron commented

what is the current state of this discussion? Has anyone released anything that addresses the goals mentioned here?