On /admin/content/node --
Check the 'Select all' checkbox in the non-floating header, the floating header remains unchecked.
Check the 'Select all' checkbox in the floating header, uncheck it in the non-floating header, the floating header remains checked.
Check the 'Select all' checkbox in either header, uncheck any other checkbox, the non-floating header is unchecked (correctly), the floating header remains checked.

CommentFileSizeAuthor
#22 core_js_select_all_sticky-218470-22.patch780 bytesalbert volkman
#19 core-js-select-all-sticky-218470-17-D7.patch783 bytesalbert volkman
#17 core-js-select-all-sticky-218470-17-D7.patch783 bytesnod_
#17 core-js-select-all-sticky-218470-17.patch803 bytesnod_
#14 tableselect-tableheader.patch919 bytescasey
#5 table-sa2.patch815 bytesredndahead
#2 table-sa.patch819 bytesredndahead

Comments

LAsan’s picture

LAsan commented
Version: 6.x-dev » 7.x-dev

Confirmed. Same happens in 7.x-dev.

redndahead’s picture

redndahead commented
Status: Active » Needs review
StatusFileSize
new table-sa.patch819 bytes

Here is a patch to include the cloned header on update. One thing that this patch will miss is when the select all box is checked on page load. The issue is the cloned table header is loaded after the update of the select all box on the initial load. Not sure when this will come up.

EDIT: Nevermind on the initial load the js will clone the checked state also.

drewish’s picture

drewish commented

i wonder if it's related but i'd noticed that the header isn't fully cloned when it start floating. if you set a class on the fixed header once it starts floating the formatting is lost until it stops floating.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Needs work

The last submitted patch failed testing.

redndahead’s picture

redndahead commented
Status: Needs work » Needs review
StatusFileSize
new table-sa2.patch815 bytes

Now improved with a reroll and 4 less bytes. Get it now while it's hot.

Status: Needs review » Needs work

The last submitted patch failed testing.

redndahead’s picture

redndahead commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch failed testing.

redndahead’s picture

redndahead commented
Status: Needs work » Needs review

Hmm don't see how this patch could make the file naming test fail. Maybe bad result? Moving back to review

cburschka’s picture

cburschka
they
commented

I have submitted the patch for re-testing.

Status: Needs review » Needs work

The last submitted patch failed testing.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Needs work » Needs review
catch’s picture

catch
he/him
Primary language English
commented
Status: Needs review » Needs work

I can't see the select all checkbox in the floating table header at all (ff3/ubuntu) - with or without the patch.

casey’s picture

casey commented
Status: Needs work » Needs review
StatusFileSize
new tableselect-tableheader.patch919 bytes

Even smaller patch.

I do see the select-all checkbox (FF3/XP).

casey’s picture

casey commented

Still applies. anyone?

casey’s picture

casey commented

#14: tableselect-tableheader.patch queued for re-testing.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Version: 7.x-dev » 8.x-dev
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new core-js-select-all-sticky-218470-17.patch803 bytes
new core-js-select-all-sticky-218470-17-D7.patch783 bytes

just a reroll, don't credit me.

Works fine, 'nuf said :)

catch’s picture

catch
he/him
Primary language English
commented
Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)
Issue tags: +Needs backport to D7
albert volkman’s picture

albert volkman commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new core-js-select-all-sticky-218470-17-D7.patch783 bytes

Reuploading nod_'s D7 patch from #17 for testbot.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs review » Reviewed & tested by the community
David_Rothstein’s picture

David_Rothstein commented
Version: 7.x-dev » 6.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Committed to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/efd12ac

Moving to 6.x for possible backport.

albert volkman’s picture

albert volkman commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new core_js_select_all_sticky-218470-22.patch780 bytes

D6 backport.

Status: Needs review » Closed (outdated)

Automatically closed because Drupal 6 is no longer supported. If the issue verifiably applies to later versions, please reopen with details and update the version.