Download & Extend
Issues

Floating tableheader: 'Select all' checkbox not updated

Posted by webernet on February 6, 2008 at 2:26pm
Project:Drupal core
Version:6.x-dev
Component:javascript
Category:bug report
Priority:minor
Assigned:Unassigned
Status:needs review
Issue tags:needs backport to D7

Issue Summary

On /admin/content/node --
Check the 'Select all' checkbox in the non-floating header, the floating header remains unchecked.
Check the 'Select all' checkbox in the floating header, uncheck it in the non-floating header, the floating header remains checked.
Check the 'Select all' checkbox in either header, uncheck any other checkbox, the non-floating header is unchecked (correctly), the floating header remains checked.

Login or register to post comments

Comments

#1

Posted by LAsan on March 24, 2008 at 6:04pm
Version:6.x-dev» 7.x-dev

Confirmed. Same happens in 7.x-dev.

#2

Posted by redndahead on September 28, 2008 at 1:27am
Status:active» needs review

Here is a patch to include the cloned header on update. One thing that this patch will miss is when the select all box is checked on page load. The issue is the cloned table header is loaded after the update of the select all box on the initial load. Not sure when this will come up.

EDIT: Nevermind on the initial load the js will clone the checked state also.

AttachmentSizeStatusTest resultOperations
table-sa.patch819 bytesIdleFailed: Failed to apply patch.View details | Re-test

#3

Posted by drewish on September 29, 2008 at 8:44pm

i wonder if it's related but i'd noticed that the header isn't fully cloned when it start floating. if you set a class on the fixed header once it starts floating the formatting is lost until it stops floating.

#4

Posted by Anonymous (not verified) on November 12, 2008 at 6:25am
Status:needs review» needs work

The last submitted patch failed testing.

#5

Posted by redndahead on November 12, 2008 at 10:47pm
Status:needs work» needs review

Now improved with a reroll and 4 less bytes. Get it now while it's hot.

AttachmentSizeStatusTest resultOperations
table-sa2.patch815 bytesIdlePassed: 11624 passes, 0 fails, 0 exceptionsView details | Re-test

#6

Posted by System Message on November 16, 2008 at 10:05pm
Status:needs review» needs work

The last submitted patch failed testing.

#7

Posted by redndahead on November 17, 2008 at 8:05am
Status:needs work» needs review

#8

Posted by System Message on January 21, 2009 at 6:10am
Status:needs review» needs work

The last submitted patch failed testing.

#9

Posted by redndahead on January 22, 2009 at 3:48am
Status:needs work» needs review

Hmm don't see how this patch could make the file naming test fail. Maybe bad result? Moving back to review

#10

Posted by cburschka on April 10, 2009 at 11:57am

I have submitted the patch for re-testing.

#11

Posted by System Message on May 25, 2009 at 3:20am
Status:needs review» needs work

The last submitted patch failed testing.

#12

Posted by webchick on May 25, 2009 at 4:50am
Status:needs work» needs review

#13

Posted by catch on June 9, 2009 at 12:21pm
Status:needs review» needs work

I can't see the select all checkbox in the floating table header at all (ff3/ubuntu) - with or without the patch.

#14

Posted by casey on May 13, 2010 at 4:00pm
Status:needs work» needs review

Even smaller patch.

I do see the select-all checkbox (FF3/XP).

AttachmentSizeStatusTest resultOperations
tableselect-tableheader.patch919 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 23,291 pass(es).View details | Re-test

#15

Posted by casey on July 22, 2010 at 8:21pm

Still applies. anyone?

#16

Posted by casey on August 25, 2010 at 2:24pm

#14: tableselect-tableheader.patch queued for re-testing.

#17

Posted by nod_ on February 21, 2012 at 10:34am
Version:7.x-dev» 8.x-dev
Status:needs review» reviewed & tested by the community

just a reroll, don't credit me.

Works fine, 'nuf said :)

AttachmentSizeStatusTest resultOperations
core-js-select-all-sticky-218470-17.patch803 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 34,583 pass(es).View details | Re-test
core-js-select-all-sticky-218470-17-D7.patch783 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 38,281 pass(es).View details | Re-test

#18

Posted by catch on February 27, 2012 at 3:44am
Version:8.x-dev» 7.x-dev
Status:reviewed & tested by the community» patch (to be ported)

#19

Posted by Albert Volkman on March 5, 2012 at 9:55pm
Status:patch (to be ported)» needs review

Reuploading nod_'s D7 patch from #17 for testbot.

AttachmentSizeStatusTest resultOperations
core-js-select-all-sticky-218470-17-D7.patch783 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 38,277 pass(es).View details | Re-test

#20

Posted by nod_ on May 30, 2012 at 7:03pm
Status:needs review» reviewed & tested by the community

#21

Posted by David_Rothstein on June 23, 2012 at 4:35pm
Version:7.x-dev» 6.x-dev
Status:reviewed & tested by the community» patch (to be ported)

Committed to 7.x - thanks! http://drupalcode.org/project/drupal.git/commit/efd12ac

Moving to 6.x for possible backport.

#22

Posted by Albert Volkman on June 24, 2012 at 5:39pm
Status:patch (to be ported)» needs review

D6 backport.

AttachmentSizeStatusTest resultOperations
core_js_select_all_sticky-218470-22.patch780 bytesIdlePASSED: [[SimpleTest]]: [MySQL] 190 pass(es).View details | Re-test
nobody click here