Post Propagation Direction is behaving in a way that's confusing to me. I think it's a bug, but maybe I'm misunderstanding it :-)
I don't wish to have group posts propagated in either direction, so I set Post Propagation Direction = none.
This has the side effect of causing the module to ignore the Parents setting when I create a subgroup.
Setting Post Propagation Direction = "Up the tree" allows the Parent setting to be saved.
I did some digging around ... hopefully I'm not about to make a fool of myself:
In hook_nodeapi in V2.0, the parents of a subgroup were saved with:
og_subgroups_save_parents($node->nid, $node->parents);
In 3.0-dev, it appears to be saved with:
og_subgroups_save_family($node, variable_get('og_subgroups_prop_type', 'none'));
In function og_subgroups_save_family there's the following:
<?php
if ($family_type == 'none') {
return FALSE;
}
?>I think some logic needs to be added to distinguish between group content nodes and subgroup nodes.
Thanks!
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | 218747.patch | 2.37 KB | ezra-g |
Comments
Comment #1
dale42Gave issue a better title
Comment #2
ezra-g commentedThanks for the troubleshooting, torelad! This patch could use some testing. I removed the
from og_subgroups_save_family() and added a check in og_subgroups_get_family() to skip parent\child propagation when propagation direction is set to 'none' .
Propagation of og homepage nodes and non-og homepage nodes worked as desired for me with propagation set to 'none' and when set to 'parents' with these changes.
Comment #3
ezra-g commentedFixed in 5.x.3.0 . Thanks to torelad for initial troubleshooting!
Comment #4
ezra-g commentedThis was Commit #103127 .
Comment #5
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.