I am working on a site built on D6 set to launch real soon now that uses Fivestar. I tracked down a couple of bugs and add one small feature, which are included in the attached patch.

The bug fixes should be self explanatory. The only serious thing I saw was a call-time pass by reference when returning fivestar_custom_widget()in line 841. The rest of the changes just squelch miscellaneous warnings.

The added feature is the option to pass the FiveStar widget to the theming layer as a template variable (in addition to above / below the content) for those who want to allow maximum flexibility in theming the widget on nodes.

CommentFileSizeAuthor
small-d6-fixes.patch2.89 KBdavideads

Comments

cburschka’s picture

cburschka
they
commented

You are trying to apply a trivial fix by wrapping in_preview in an empty() - but that ignores the cause, which is that in_preview was done away with entirely. I made a separate patch for this. #221168: $node->in_preview no longer exists

cburschka’s picture

cburschka
they
commented
Status: Needs review » Needs work

(Whether this patch fixes the problem, or my patch gets in first and creates a conflict, this will need to be changed either way.)

davideads’s picture

davideads commented

Thanks, Arancaytar -- I was in rush mode. I should create individual patches.

quicksketch’s picture

quicksketch
he/him
commented
Status: Needs work » Fixed

davideads, I've committed all your changes (or they've been committed in other patches), except the new display mode and including fivestar widget in the preprocessing. I've thought about doing this for some time, though in hook_nodeapi $op == 'load'. Please open another issue for that request.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.